Conversation
Emit xmlns:metroninfo, xmlns:xsd, xmlns:xsi, and xsi:schemaLocation on the <MetronInfo> root element to match the upstream schema's expected format. Schema validation now checks the serialized XML bytes rather than the live ElementTree object, since xmlschema misreads xmlns:* attributes set directly on an in-memory Element as regular attributes instead of namespace declarations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xmlns:metroninfo,xmlns:xsd,xmlns:xsi, andxsi:schemaLocationon the<MetronInfo>root element when writing/serializing MetronInfo XML, matching the format expected by the upstream schema.ElementTreeobject, sincexmlschemamisreadsxmlns:*attributes set directly on an in-memoryElementas regular (disallowed) attributes instead of namespace declarations — validating the actual bytes that get written avoids this and removes an order-dependency between attaching the attributes and validating.