Skip to content

Add mcoplib mcoplib profiler bool env #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghangz wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add mcoplib mcoplib profiler bool env #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
588ac8d
Accept common false values for profiler env
ghangz Jul 1, 2026
89a3412
Simplify profiler boolean environment parsing
ghangz Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions mcoplib/profiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,10 @@

def _is_profiler_enabled() -> bool:
"""
Env switch: PROFILER_ENABLED==0 -> disabled, else enabled.
Env switch: PROFILER_ENABLED=false/0/off/no -> disabled, else enabled.
"""
v = os.getenv("PROFILER_ENABLED", "1")
try:
return not (str(v).strip() == "0")
except Exception:
return True
return v.strip().lower() not in {"0", "false", "off", "no"}


def _timestamp() -> str:
Expand Down
12 changes: 12 additions & 0 deletions unit_test/test_profiler_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
from mcoplib.profiler import _is_profiler_enabled


def test_profiler_disabled_by_common_false_values(monkeypatch):
for value in ("0", "false", "False", "off", "NO"):
monkeypatch.setenv("PROFILER_ENABLED", value)
assert not _is_profiler_enabled()


def test_profiler_enabled_by_default(monkeypatch):
monkeypatch.delenv("PROFILER_ENABLED", raising=False)
assert _is_profiler_enabled()