Repository navigation
Log reconciliation conflicts at info instead of error - #73
Merged
antiguru merged 2 commits intoOct 19, 2026
Merged
Conversation
A reconciliation that fails because the object changed since the controller read it resolves on its own when retried against the newer version. This happens routinely whenever the cache lags the API server, for instance after a leadership change, and logging each one at error floods error trackers. Error::is_conflict classifies a 409 Conflict anywhere in the source chain and a failed test operation in the finalizer patch, which the API server reports as a 422 without object details. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Alphadelta14
previously approved these changes
Oct 19, 2026
antiguru
marked this pull request as ready for review
October 19, 2026 15:44
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
antiguru
changed the title
Alphadelta14
approved these changes
Oct 19, 2026
Merged
antiguru
added a commit
to MaterializeInc/materialize
that referenced
this pull request
Oct 20, 2026
k8s-controller 0.14.1 logs reconciliation conflicts at info instead of error (MaterializeInc/k8s-controller#73). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reconciliation that fails because the object changed since the controller read it resolves on its own when the object is retried at its newer version. With leader election this happens on every leadership change, since the new leader reconciles from a cache that lags the API server. Each failure is logged at
error, so orchestratord sends a Sentry event per failure, which uses up our error budget.Error::is_conflicttreats two cases as conflicts. The first is a409 Conflictanywhere in the source chain. The second is a failedtestoperation in the finalizer patch, which the API server reports as a 422 without object details.reconcilelogs these atinfo.AlreadyExistsand validation 422s are still logged aterror.🤖 Generated with Claude Code