fix(easy): Only back-quote parser tokens#335
Merged
Merged
Conversation
When reviewing cargo moving fron `toml-rs` (hand-rolled parser) to `toml_edit` (`combine`-based parser), one piece of feedback was about only wanting tokens quoted and not textual descriptions. It looks like `combine` tracks all of the needed information and just a re-formatting of the output is needed. Fixes Marwes#334
3 tasks
Marwes
approved these changes
Jan 11, 2022
Marwes
left a comment
Marwes
left a comment
Owner
There was a problem hiding this comment.
I misunderstood the issue then LGTM.
4 tasks
Contributor
Author
|
Is there an ETA on a merge and release for this? This is the only remaining blocker for rust-lang/cargo#10086 (merging toml_edit into cargo). #336 has less of an impact and so they aren't blocking on it. |
Owner
|
Had issues with travis-ci yesterday so had to switch to, and wait for github actions (and then I forgot about it). Rleeased now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reviewing cargo moving fron
toml-rs(hand-rolled parser) totoml_edit(combine-based parser), one piece of feedback was aboutonly wanting tokens quoted and not textual descriptions. It looks like
combinetracks all of the needed information and just a re-formattingof the output is needed.
Fixes #334