Incorporate topology - #349
Draft
J15525 wants to merge 5 commits into
Draft
Conversation
This was
linked to
issues
Mar 30, 2026
Contributor
|
This has to wait for SkeletonTopology to be finished. |
apalha
self-requested a review
March 30, 2026 15:24
apalha
requested changes
Mar 30, 2026
apalha
left a comment
apalha
left a comment
Contributor
There was a problem hiding this comment.
Needs to wait for SkeletonTopology.
Collaborator
Author
I also haven't finished everything yet. I just made it a draft pull request to make it more visible and trackable. |
Contributor
|
This is full of merge conflicts... |
Collaborator
Author
Should be better now, I forgot to select to right branch to merge to. |
J15525
force-pushed
the
305-feat-incorporate-topology
branch
5 times, most recently
from
September 10, 2026 13:53
d1fde80 to
b7c3442
Compare
J15525
force-pushed
the
305-feat-incorporate-topology
branch
from
September 10, 2026 14:34
b7c3442 to
26644a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces topology to the other modules within Mantis. In particular, it ensures that
GeometryandFunctionSpacesare aware of this new struct. This means that the multi-patch setting can be handled uniformly using information from topology.