uses .icns file instead of lowres png to set icon on macOS (issue #1143)#1251
Open
thoellt wants to merge 1 commit into
Open
uses .icns file instead of lowres png to set icon on macOS (issue #1143)#1251thoellt wants to merge 1 commit into
thoellt wants to merge 1 commit into
Conversation
This change makes the app use the .icns file to create the icon on macOS, instead of a single resolution png. Ultimately this is an outdate fix though, as macOS uses a new icon format since macOS 26.
Contributor
|
@sbvis could you perhaps take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #1143 by changing two calls that set the default app icon to use the existing .icns file, instead of a single resolution png.
It does not address custom icons. It might be good to allow for other resources than images to create those later one. However, at least for macOS there is also a new icon format from macOS 26 on, so it would probably be best to combine addition of the new icon format with deeper integrations like custom icons in a later update.