Fix for the d interface problem in Issue 1984#4361
Merged
Conversation
Member
|
This should probably wait until the great sort (#4347) is merged and rebased on top of that with the new file locations |
d-torrance
requested changes
Jun 6, 2026
d-torrance
left a comment
d-torrance
left a comment
Member
There was a problem hiding this comment.
@ddale27 - Would you fix the conflicts now that the "Great Sort" PR has been merged?
Member
Author
|
Sure, I'll fix them tomorrow. |
Member
Author
|
The conflicts should be fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the problems that Claude identified in Issue #1984 was that C++ exceptions were propagating up to the d interface through certain RingElement operations, causing unrecoverable errors. This pull request partially fixes this issue by converting these C++ exceptions into ERROR throws, which the d interpreter can recover from.
It does not fix the issue of
monomialOrderDecodeToActualExponentsblindly using the block of memory allocated fortmpexp, which seems to be the core cause of the exception throws. It also does not fix any of the identified problems in thesuperRingpackage.I would be happy to implement a fix for the issue with
monomialOrderDecodeToActualExponents, but I am not interested in working onsuperRing.Additionally, I did not write any unit tests for this issue, since I was unable to reproduce it on my machines.
AI Disclosure
These changes were based on code and code analysis written by Claude at #1984.