Skip to content

fix(sosa-lint): exclude .env.example/.sample/.template from secret check#23

Open
MichalOpsAgents wants to merge 12 commits into
MSApps-Mobile:mainfrom
MichalOpsAgents:main
Open

fix(sosa-lint): exclude .env.example/.sample/.template from secret check#23
MichalOpsAgents wants to merge 12 commits into
MSApps-Mobile:mainfrom
MichalOpsAgents:main

Conversation

@MichalOpsAgents

Copy link
Copy Markdown
Contributor

Problem

The .env.* pattern in scripts/sosa-lint.sh was matching .env.example files, which are safe to commit (they contain placeholder values, not real credentials).

This caused a false-positive SOSA lint failure for the opsagent-shopify plugin, which has mcp-server/.env.example.

Fix

Added ! -name '*.example' ! -name '*.sample' ! -name '*.template' exclusions to the find command on line 80 of sosa-lint.sh.

# Before
find "$dir" -name ".env" -o -name ".env.*"

# After  
find "$dir" \( -name ".env" -o -name ".env.*" \) ! -name "*.example" ! -name "*.sample" ! -name "*.template"

Impact

  • Fixes the failing CI on the latest push
  • .env.example files remain committable (good practice — shows required vars without leaking values)
  • Real .env files are still blocked

The .env.* pattern was matching .env.example files which are safe to commit
(they contain placeholder values, not real credentials). Added exclusions for
*.example, *.sample, and *.template suffixes.

Fixes: opsagent-shopify/mcp-server/.env.example triggering false positive.
…l (use upstream copy in installed plugin); README to follow
…e only in .plugin (cli-gateway transport limit)
@MichalOpsAgents

Copy link
Copy Markdown
Contributor Author

CTO review (2026-05-11): this PR is blocked from merge on two grounds — (1) mergeStateStatus: DIRTY / mergeable: CONFLICTING against main, and (2) scope creep. The title says fix(sosa-lint): exclude .env.example/.sample/.template but the diff is +1389/-1 across 9 files spanning the sosa-lint script plus a brand-new adobe-for-creativity-opsagents plugin plus a new opsagents-studio-dev skill in opsagent-shopify.

Request: split into 3 PRs — (a) the one-line scripts/sosa-lint.sh fix, (b) the Adobe plugin, (c) the opsagents-studio-dev skill. The sosa-lint fix can merge today once rebased; the other two need their own review surface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant