fix(sosa-lint): exclude .env.example/.sample/.template from secret check#23
Open
MichalOpsAgents wants to merge 12 commits into
Open
fix(sosa-lint): exclude .env.example/.sample/.template from secret check#23MichalOpsAgents wants to merge 12 commits into
MichalOpsAgents wants to merge 12 commits into
Conversation
The .env.* pattern was matching .env.example files which are safe to commit (they contain placeholder values, not real credentials). Added exclusions for *.example, *.sample, and *.template suffixes. Fixes: opsagent-shopify/mcp-server/.env.example triggering false positive.
… design-from-template skill
… resize intake form asset
…l (use upstream copy in installed plugin); README to follow
…ummary + install pointer
…e only in .plugin (cli-gateway transport limit)
Contributor
Author
|
CTO review (2026-05-11): this PR is blocked from merge on two grounds — (1) Request: split into 3 PRs — (a) the one-line |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
.env.*pattern inscripts/sosa-lint.shwas matching.env.examplefiles, which are safe to commit (they contain placeholder values, not real credentials).This caused a false-positive SOSA lint failure for the
opsagent-shopifyplugin, which hasmcp-server/.env.example.Fix
Added
! -name '*.example' ! -name '*.sample' ! -name '*.template'exclusions to thefindcommand on line 80 ofsosa-lint.sh.Impact
.env.examplefiles remain committable (good practice — shows required vars without leaking values).envfiles are still blocked