Repository navigation
feat: add the Vibe Coding Mad Libs challenge - #11
Conversation
theycallmeswift
left a comment
There was a problem hiding this comment.
Independent review of ebea405 against issue #6, the challenge spec, boothstrap's base skill and authoring guide, and docs/style/, with a live smoke test of the preview server.
Verdict: changes needed. One blocking item (the typed-sentence fallback rejects a sentence without a trailing period) and five nits. The owner wants nits addressed too, so please take all six.
Checked: npm run verify ok, npm test 68/68, npm run lint 0 issues, no conflict with main, CI run 38815924636 green on this head. Smoke test: a busy port fails setup with a clear message and leaves the other listener alone; on a free port setup exits while the server keeps running in its own process group, bound only to 127.0.0.1; path traversal, encoded variants, the state file, and dice-sheet.md all 404 with no directory listing; a foreign Host gets 403; /__stop without the token gets 403; the state file is mode 600; cleanup twice exits 0 and leaves nothing listening. The lockfile resolves every entry to registry.npmjs.org with integrity hashes and pins all eight @earendil-works/* packages at 1.0.4; the overrides claim holds, since without them the siblings land on 1.3.0 and Pi 1.0.4's index fails to import. The extension API use matches the 1.0.4 typings.
Decide items: 1 (shared intro ignore) and 3 (verify prints the path) are sound. 2 (network install test) is sound but incomplete; see the inline comment on the test.
Generated by Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018Q8wNEF5bh6UMEZ94TdGLD
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018Q8wNEF5bh6UMEZ94TdGLD
Adds
vibe-coding-mad-libs/, a 10-minute terminal challenge. The participant fills four Mad Libs blanks in a Pi extension form. Pi builds a self-containedindex.htmlserved onhttp://127.0.0.1:4321/, offers it throughshow_preview, then makes one change the participant asks for.Closes #6
mad-libs.mjsis declared inplugin.jsonunderpi_extensions./mad-libsreopens it.installrunsnpm ciinto the package. The lock pins@earendil-works/pi-coding-agentand its@earendil-works/*siblings at 1.0.4 throughoverrides. Without that,^1.0.4resolves the siblings to 1.3.0, and pi-coding-agent 1.0.4's index fails to load.preview.mjsruns the server in setup's process group and reports readiness over IPC.setupexits once the server answers, and fails when the port is busy.cleanupstops the server with a token kept in the workspace, so it never stops a listener it didn't start.index.html.Decide
Lint fix shared with Ship the hello-world challenge #5 and Ship the BirdsBirdBirds challenge #7.
.markdownlint-cli2.jsoncignores*/intro.md, because the challenge spec bars a title there and MD041 requires one. All three PRs carry the same hunk, so they merge cleanly. Recommend: keep it.The install test uses the network. It is the only test that does, and only to reach the npm registry, as the issue allows. Three places still contradict it:
AGENTS.md: "Tests run offline, with no model calls and no credentials".docs/style/testing.md: its offline rule.docs/style/testing.md: "A test that needs a package's dependencies uses a fixture that has none".All three are outside this PR's Owns. Recommend: the orchestrator's follow-up root PR adds the exception to
AGENTS.mdandtesting.md, alongside the README challenge index.The
npm run verifyline. It printsok <absolute path>/vibe-coding-mad-libs; that format comes fromtools/verify.mjs. Recommend: accept it as is.Ready gate
npm run verify:ok …/vibe-coding-mad-libs.npm test: 81 pass, 0 fail, 0 skipped.npm run lint: 0 issues. Nopreview.mjs serveprocess is left after the run. CI is green on 880a27f: run 38817446862.isFinishedPromptrejected the no-period and "!" sentences; the new cases cover them. The vowel-article test fails against the originalprompt.mjs. The busy-port and crash-cleanup tests check that the other listener still answers.vibe-coding-mad-libs/README.mdwith the standalone run. The root README index,AGENTS.md, andtesting.mdare left to the orchestrator (see Decide).google/gemini-3.8-flashwith the realGEMINI_API_KEY, runningsetupandcleanupby hand. Details below.docs/style/. Cut the form's key list from the skill, since the form shows its keys, and dropped the token status handshake.Standalone run:
show_previewis missing outside boothstrap.build-apponly after confirmation.index.html; Pi acknowledgedimprove-appafter confirmation.cleanupstopped the server.🤖 Generated with Claude Code
https://claude.ai/code/session_018Q8wNEF5bh6UMEZ94TdGLD