Repository navigation
feat: add hello-world challenge - #10
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CEbhAEZ6EVyZAHiLSiAXjG
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CEbhAEZ6EVyZAHiLSiAXjG
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CEbhAEZ6EVyZAHiLSiAXjG
theycallmeswift
left a comment
There was a problem hiding this comment.
Independent review of e0db6de against issue #5, the challenge spec, boothstrap's base skill and authoring guide, and docs/style/.
Verdict: changes needed. One blocking item (the intro.md heading) and six nits. The owner wants nits addressed too, so please take all seven.
Checked: npm run verify ok, npm test 30/30, npm run lint 0 issues, no conflict with main, CI run 38815155352 green on this head. Only the Owns paths changed and no dependencies were added. The Pi pins in the README match both the pinned boothstrap 0.0.2 and boothstrap main. The skill has no duplication with the base skill and keeps the standalone fallback.
Decide items: 2 (done_when requires the text, not a byte match) is sound. 1 (cleanup always exits 0) is only partly sound; see the inline comment on cleanup.
For the owner, outside this PR's Owns: the root README's challenge index still says "None yet", and AGENTS.md and docs/style/testing.md describe test/ as tests for tools/ only. The orchestrator will carry those in a follow-up root PR once the three challenge PRs land.
Generated by Claude Code
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CEbhAEZ6EVyZAHiLSiAXjG
Adds the
hello-worldterminal challenge: Pi reads a seededwelcome.txt, greets the participant, then createshello.txtcontainingHello, world!.Closes #5
Decide
cleanupisset -euplus a plainrm -fof the seededwelcome.txt, so it is idempotent and safe after a failedsetupwithout hiding real failures. Recommend: keep it, because the station already handles a failing cleanup.done_whenforhello-filerequires the textHello, world!, not an exact byte match, so a trailing newline from the model doesn't send the participant into a rewrite loop. Recommend: keep it, because the hint and intro don't mention newlines..markdownlint-cli2.jsoncignores*/intro.md, because the challenge spec bars a title there and MD041 requires one. This is a shared fix carried by Ship the hello-world challenge #5, Ship the Vibe Coding Mad Libs challenge #6, and Ship the BirdsBirdBirds challenge #7, byte-identical across them; it no-ops oncemainhas it. Recommend: keep it, because the Intro screen shows the title from the manifest.Ready gate
npm run verifyprintsok .../hello-world;npm testpasses 30/30;npm run lintreports 0 issues. CI is green on d5498a2: run 38816099539.hello-world/README.mdcarries the standalone Pi commandsGEMINI_API_KEY, Pi 1.0.4,google/gemini-3.8-flash, in a scratch folder aftersetup:/skill:start-challengegreeted me, asking to readwelcome.txtgave the greeting and thegreetmessage, asking forhello.txtproduced the file withHello, world!and thehello-filemessage.cleanupran twice, leaving onlyhello.txt. No station playthrough; that is a later issue.docs/style/, and the spec; its findings are fixed.markdownlint-cli2.jsoncignore added; no secrets🤖 Generated with Claude Code
https://claude.ai/code/session_01CEbhAEZ6EVyZAHiLSiAXjG