Skip to content

feat: add hello-world challenge - #10

Merged
theycallmeswift merged 4 commits into
mainfrom
feat/hello-world-challenge
Oct 16, 2026
Merged

theycallmeswift merged 4 commits into
mainfrom
feat/hello-world-challenge

Conversation

@theycallmeswift

@theycallmeswift theycallmeswift commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Adds the hello-world terminal challenge: Pi reads a seeded welcome.txt, greets the participant, then creates hello.txt containing Hello, world!.

Closes #5

Decide

  • cleanup is set -eu plus a plain rm -f of the seeded welcome.txt, so it is idempotent and safe after a failed setup without hiding real failures. Recommend: keep it, because the station already handles a failing cleanup.
  • done_when for hello-file requires the text Hello, world!, not an exact byte match, so a trailing newline from the model doesn't send the participant into a rewrite loop. Recommend: keep it, because the hint and intro don't mention newlines.
  • .markdownlint-cli2.jsonc ignores */intro.md, because the challenge spec bars a title there and MD041 requires one. This is a shared fix carried by Ship the hello-world challenge #5, Ship the Vibe Coding Mad Libs challenge #6, and Ship the BirdsBirdBirds challenge #7, byte-identical across them; it no-ops once main has it. Recommend: keep it, because the Intro screen shows the title from the manifest.

Ready gate

Step Evidence
Tests and lint Locally on Node 26.12: npm run verify prints ok .../hello-world; npm test passes 30/30; npm run lint reports 0 issues. CI is green on d5498a2: run 38816099539.
Red run n/a: new package
Sibling sweep n/a: first challenge package
Docs and specs hello-world/README.md carries the standalone Pi commands
Standalone run Ran with GEMINI_API_KEY, Pi 1.0.4, google/gemini-3.8-flash, in a scratch folder after setup: /skill:start-challenge greeted me, asking to read welcome.txt gave the greeting and the greet message, asking for hello.txt produced the file with Hello, world! and the hello-file message. cleanup ran twice, leaving only hello.txt. No station playthrough; that is a later issue.
Editorial pass An independent subagent reviewed against #5, docs/style/, and the spec; its findings are fixed
Skipped tests None
Secrets, permissions Only .markdownlint-cli2.jsonc ignore added; no secrets

🤖 Generated with Claude Code

https://claude.ai/code/session_01CEbhAEZ6EVyZAHiLSiAXjG

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CEbhAEZ6EVyZAHiLSiAXjG
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CEbhAEZ6EVyZAHiLSiAXjG
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CEbhAEZ6EVyZAHiLSiAXjG

@theycallmeswift theycallmeswift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review of e0db6de against issue #5, the challenge spec, boothstrap's base skill and authoring guide, and docs/style/.

Verdict: changes needed. One blocking item (the intro.md heading) and six nits. The owner wants nits addressed too, so please take all seven.

Checked: npm run verify ok, npm test 30/30, npm run lint 0 issues, no conflict with main, CI run 38815155352 green on this head. Only the Owns paths changed and no dependencies were added. The Pi pins in the README match both the pinned boothstrap 0.0.2 and boothstrap main. The skill has no duplication with the base skill and keeps the standalone fallback.

Decide items: 2 (done_when requires the text, not a byte match) is sound. 1 (cleanup always exits 0) is only partly sound; see the inline comment on cleanup.

For the owner, outside this PR's Owns: the root README's challenge index still says "None yet", and AGENTS.md and docs/style/testing.md describe test/ as tests for tools/ only. The orchestrator will carry those in a follow-up root PR once the three challenge PRs land.


Generated by Claude Code

Comment thread hello-world/intro.md Resolved
Comment thread hello-world/intro.md Resolved
Comment thread hello-world/cleanup Resolved
Comment thread test/hello-world.test.mjs Resolved
Comment thread test/hello-world.test.mjs Resolved
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CEbhAEZ6EVyZAHiLSiAXjG
@theycallmeswift
theycallmeswift marked this pull request as ready for review October 15, 2026 22:18
@theycallmeswift theycallmeswift self-assigned this Oct 15, 2026
@theycallmeswift
theycallmeswift merged commit dfe64ab into main Oct 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ship the hello-world challenge

2 participants