Repository navigation
[pull] canary from vercel:canary - #2097
Merged
Merged
Conversation
## Summary End the App Router HTML render span and client-component load tracking from the same SSR completion callback. This follows #99322’s move to HTML-render-scoped telemetry and keeps the two measurements from drifting to different completion points. Node retains its immediate `onAllReady` boundary; Web SSR handles both fulfilled and rejected `allReady` outcomes. Prerender and error-recovery behavior are unchanged. ## Verification - Existing streamed-render telemetry tests: dev Webpack and production Turbopack, 5 passed each. - Production Webpack standalone/Edge suite: 2 passed. - Existing logger and response-piping unit tests: 11 passed. <!-- NEXT_JS_LLM -->
Offer a direct environment switch when the active Client or Server filter has no rows but the other environment has sources matching the selected file types. Keep the generic empty state when neither environment has matching sources. <!-- NEXT_JS_LLM --> --------- Co-authored-by: vercel-fleet-prod[bot] <318278635+vercel-fleet-prod[bot]@users.noreply.github.com> Co-authored-by: Will Binns-Smith <755844+wbinnssmith@users.noreply.github.com>
## Summary Enable the Rust React compiler when building the bundle analyzer UI. Update its pinned Next.js version to one that supports the compiler option. ## Verification - `pnpm --filter @next/bundle-analyzer-ui build` <!-- NEXT_JS_LLM --> --------- Co-authored-by: vercel-fleet-prod[bot] <318278635+vercel-fleet-prod[bot]@users.noreply.github.com> Co-authored-by: Will Binns-Smith <755844+wbinnssmith@users.noreply.github.com>
Fix route selector overflow for long route names and constrain the popover to the viewport. Deduplicate route names when generating analyzer data and before rendering the picker so parallel routes and existing analyzer corpora cannot produce duplicate command items. <!-- NEXT_JS_LLM --> Co-authored-by: vercel-fleet-prod[bot] <318278635+vercel-fleet-prod[bot]@users.noreply.github.com> Co-authored-by: Will Binns-Smith <755844+wbinnssmith@users.noreply.github.com>
This comment is just as valuable in the mirror. Forks disable GH Actions by default nowadays. Individual workflows can also be disabled. That avenue should be chosen instead of hardcoding disablement in the workflow file.
`build_reusable.yml` now defines `NEXT_TEST_PREVIEW_BUILDS_BASE_URL` next to `PREVIEW_BUILDS_ACCESS`, so every test job inherits both via `process.env` instead of relying on per-call-site threading. The same class of gap on next-15-5 broke private-preview deploy tests in the mirror with an E401 ([failing run](https://github.com/vercel/next-js-mirror/actions/runs/36334147525/job/108664261165)). ## test plan - [x] [test_e2e_deploy_release run](https://github.com/vercel/next.js/actions/runs/36347194442) Co-authored-by: Claude Code (kimi-k3[1m]) <noreply@anthropic.com>
Track explicit directories while continuing to warn for unsupported module and package inputs. I will keep removing more and more of the unsupported cases with each PR
Adds support for resolving build dependencies to modules (cjs or mjs) the way that webpack does. There is more support, but this was a nice isolatable slice.
### What? Remove the eight unit tests added to the manual filesystem-watcher fuzzer by #98982 and #98983. ### Why? This follows up on bgw's review feedback in [#98982](#98982 (comment)) and [#98983](#98983 (comment)) that unit tests are overkill for this stress-testing CLI. Its supported behavior is exercised by running the fuzzer itself. ### How? Remove only the fuzzer's `#[cfg(test)]` module. Both production fixes from the original PRs remain unchanged. Verified with: - `cargo fmt -- --check` - `cargo check -p turbo-tasks-fuzz` - `cargo clippy -p turbo-tasks-fuzz --all-targets -- -D warnings -A deprecated` - `cargo build --release -p turbo-tasks-fuzz` - 30-second manual smoke runs for normal reads, tracked read/writes, and directory symlinks (443 total iterations; no panics or terminal errors) <!-- NEXT_JS_LLM --> <!-- fleet 6488265d-2685-49d3-b632-6511b4b47690 --> Co-authored-by: vercel-fleet-prod[bot] <318278635+vercel-fleet-prod[bot]@users.noreply.github.com> Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com> Co-authored-by: Benjamin Woodruff <180404+bgw@users.noreply.github.com>
## Summary Enable seven e2e suites to validate build diagnostics on deployments. Expected build failures now use deferred `next.start()` rejection and retained build logs, preserving the routing, codemod and `after()` diagnostics. The successful `generateStaticParams` case uses deployment startup and accepts timestamp-prefixed build events. ## Verification - Production: all seven suites passed with Turbopack and Webpack, including the existing diagnostic snapshots. - Development: all six applicable suites passed with both bundlers; the existing production-only suite remains skipped in dev. - Confirmed build-event parsing preserves payloads for plain and timestamp-prefixed logs. - Formatting and ESLint passed. Deploy execution remains for CI. <!-- NEXT_JS_LLM -->
## Summary Base this PR directly on #98430 and migrate the six workspace-root inference suites from `skipDeployment` to `@force-gate !deploy`, including removal of their `skipped` early returns. This PR now contains its own conversions and no longer depends on the migration in #98156. Retain the deployment exclusions with concrete explanations: Vercel’s builder supplies `NEXT_PRIVATE_OUTPUT_TRACE_ROOT`, bypassing automatic workspace-root inference. Diagnostic assertions would not exercise that path, while successful imports and absent warnings would not establish that workspace detection worked. The home-directory boundary tests also change `HOME` for a locally managed Next.js process. ## Verification - Formatting and ESLint passed for all six files. - All 24 gate pragma-transform unit tests passed, including `describe.each` support. - Verified all six force-gates attach successfully and test logic matches #98430 after removing only the legacy deployment skip machinery. Final file contents match the previously reviewed PR head. - Deployment-mode collection and gate-runtime tests were blocked by missing `node-fetch` in the local installation; no deployments ran. - Bootstrap and watch builds were attempted but stalled without output and were stopped. <!-- NEXT_JS_LLM -->
## Summary Custom-server suites depend on local server entrypoints that deploy mode does not launch. Replace their legacy `skipDeployment` exclusions and `skipped` returns with `@force-gate !deploy` and explain the dependency, while preserving their existing local mode restrictions and assertions. This covers six test files, including the custom-server sections of API body parsing and OpenTelemetry. The ordinary API JSON body-parser case remains enabled in deploy mode; only the Express pre-parsing cases are excluded. The custom-server shutdown suite also requires the runner to signal its server process and observe `after()` completion. Stack: #99012 → #98994 → #99392 → #98911. Based on #99012; #99392 separately explains local process-control exclusions. ## Verification - The two added suites passed in both webpack development and production modes: five tests in each mode. - Collection with the real gate runtime and fixture setup stubbed confirmed all five tests enabled locally, and only the ordinary API body-parser test enabled in deploy mode. Both parameterized shutdown signals are excluded in deploy. - All 24 gate-transform tests passed. Formatting and ESLint passed for the added files. - The JavaScript workspace build passed. The full bootstrap build failed in the native Rust step (`cargo metadata failed to run`). - No new deployment was created. The ordinary API body-parser case passed in the earlier deployment experiment. <!-- NEXT_JS_LLM -->
## Summary Fill gaps in API reference history so readers can tell which Next.js 16 release stabilized an API or renamed its experimental form. - **16.0.0:** Record stabilization of `cacheLife()`, `cacheTag()`, `use cache`, the caching configuration options, React Compiler support, and Turbopack production builds. Add the missing `enablePrerenderSourceMaps` reference, shared with the Pages Router, documenting its current default and promotion out of `experimental`. - **16.2.0:** Record the promotion of `adapterPath` to a stable, top-level option. - **16.3.0:** Replace the `v16.x.x` placeholders for the `instant` and `prefetch` route exports with their stabilization version and previous names. - **16.4.0:** Clarify that the new `prefetch()` and `navigation()` functions replace names used in earlier canaries. The `catchError` and `retry` histories already correctly record introduction in 16.2.0 and stabilization in 16.3.0, so they are unchanged. ## Verification - Checked the 16.0 release and upgrade guides, PR #84877, and the configuration definitions/migrations in the v15.5.0 and v16.0.0 tags. - Checked the route exports against the v16.2.0/v16.3.0 source and stabilization commits #94578 and #94571; checked the function renames against #99241. - Checked the new source-map reference against the current config default and prerender worker implementation. - Prettier and diff checks passed. Documentation only; no runtime code changed. <!-- NEXT_JS_LLM -->
## Summary Enable deploy coverage for all six proxy export cases by checking in each `proxy.ts` variant and giving it an independent test instance with the shared app fixture. Valid exports retain their browser rendering assertions; invalid exports use rejected startup and retain the complete compiler diagnostics, replacing local file writes and repeated builds on one instance. ## Verification - All six cases pass in dev and production with Turbopack and Webpack. - Turbopack production was verified with normal fixture isolation; the local `NEXT_SKIP_ISOLATE=1` run reports a different diagnostic path. - Formatting and ESLint passed. - Deploy execution has not been run locally; this PR enables all six cases for deploy CI. <!-- NEXT_JS_LLM -->
Initialize queued tracing spans and borrow them before entering. Fix compilation with trace_leaf_distance_update enabled.
## Summary Include async client-module evaluation in loading metrics. A module with top-level `await` can make `require()` return a Promise; measuring only until that return omits the subsequent evaluation wait. This follows #99322 and addresses [Hendrik’s review](#99322 (comment)). Observe native Promise resolution and rejection while preserving the original return value and per-render attribution. Synchronous modules keep their existing behavior, including exports named `then` and thrown errors. ## Verification - End-to-end regression: a real Client Component waits five seconds during top-level `await`; an HTML request must report more than one second of accumulated loading time through the standard Performance API. The pre-fix code reported only 38 ms; the fixed code passes. - Replaced the PR-added mocked-loader tests. The existing eight logger tests remain unchanged and pass. - Full client-loading group: dev Webpack and production Turbopack, 6 passed each. Types, lint, formatting, and the full build pass. <!-- NEXT_JS_LLM -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )