Skip to content

Add Dockerfile - #45

Open
ruffsl wants to merge 7 commits into
MIT-SPARK:masterfrom
ruffsl:patch-1
Open

Add Dockerfile#45
ruffsl wants to merge 7 commits into
MIT-SPARK:masterfrom
ruffsl:patch-1

Conversation

@ruffsl

@ruffsl ruffsl commented Jan 11, 2020

Copy link
Copy Markdown
Contributor

This PR adds an example Dockerfile for building this package as well as any needed underlay repos.

Comment thread install/underlay.repos
@@ -0,0 +1,5 @@
repositories:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the point of having an overlay/underlay.repos ?
Also we should document this in the Readme.md as well.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having separate overlay and underlay workspaces allows one to avoid having to rebuild unchanged upstream dependencies that changed downstream packages rely on. You can read more on this here:
https://index.ros.org/doc/ros2/Tutorials/Colcon-Tutorial/#source-an-underlay

This is used in conjunction with docker layer caching to succinctly build arbitrary package dependencies in whatever order they may require, and still cache that workspace to be independent of the source package in development.

And perhaps more than you'd ever need to know about build tools:
http://design.ros2.org/articles/build_tool.html

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll push a commit with some updated build instructions.

@ruffsl

ruffsl commented Apr 2, 2020

Copy link
Copy Markdown
Contributor Author

@ToniRV is there anything else this PR needs for to be merged?
I'd like to reduce the number patches/forks to track for the ROS2 port.

@ToniRV

ToniRV commented Apr 28, 2020

Copy link
Copy Markdown
Contributor

@ruffsl I need to hold these PRs bcs we are in the middle of the Go-SEEK challenge, and this might break things...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants