Skip to content

feat(ws_network): add Ws_SetBroker for runtime broker override - #504

Merged
nicolas-rabault merged 1 commit into
rc_3.2.0from
feat/ws_set_broker
Apr 27, 2026
Merged

feat(ws_network): add Ws_SetBroker for runtime broker override#504
nicolas-rabault merged 1 commit into
rc_3.2.0from
feat/ws_set_broker

Conversation

@nicolas-rabault

Copy link
Copy Markdown
Member

Adds a writable 128-byte buffer behind the existing s_url pointer and exposes ws_hal_set_broker / Ws_SetBroker to override the compile-time WS_NETWORK_BROKER_ADDR default. Must be called before Ws_Init; no effect afterwards (Ws_Init captures the URL during mg_ws_connect).

Additive change: existing callers that rely on the compile-time default are unaffected.

By submiting this PR, you agree with the associated license MIT) and with our Contributor License Agreement (CLA).

Before to begin

Thank you for contributing to the Luos project!

Before to begin, please follow these steps:

  • Ensure that this PR is not a duplicate.
  • Assign @Simonbdy to this PR
  • Add the PR to the Luos contribution project

Feel free to read the Luos contribution's guidelines and the documentation page to have more insight about how to contribute to Luos.

PR Description section

Description and dependencies

Please include here a summary of the changes and the related issue. List any dependencies that are required for this change.

Changes

Please choose the relevant options:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Related issue(s)

Provide a list of the related issues that will be fixed by this PR.


WARNING: Do not edit the checklist below.


Developer section

  • [Documentation] is up to date with new feature
  • [Tests] are passed OK (non regression, new features & bug fixes)
  • [Code Quality] please check if:
    • Each function has a header (description, inputs, outputs)
    • Code is commented (particularly in hard to understand areas)
    • There are no new warnings that can be corrected
    • Commits policy is respected (constitancy commits, clear commits comments)

QA section

  • [Review] tests for new features have been reviewed
  • [Changelog] is up-to-date with expected tags
    🆕 Feature: [Feature] Description...
    🆕 Added: [Feature] Description...
    🆕 Changed: [Feature] Description...
    🛠️ Fix: [Feature] Description...

Adds a writable 128-byte buffer behind the existing s_url pointer and
exposes ws_hal_set_broker / Ws_SetBroker to override the compile-time
WS_NETWORK_BROKER_ADDR default. Must be called before Ws_Init; no effect
afterwards (Ws_Init captures the URL during mg_ws_connect).

Additive change: existing callers that rely on the compile-time default
are unaffected.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@nicolas-rabault
nicolas-rabault merged commit 76d525c into rc_3.2.0 Apr 27, 2026
47 checks passed
@nicolas-rabault
nicolas-rabault deleted the feat/ws_set_broker branch April 27, 2026 15:18
@nicolas-rabault nicolas-rabault mentioned this pull request Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant