Repository navigation
Conversation
The Coucou window is created hidden and only shown and hidden afterwards, so opening it (Settings in the island, the tray, the Start menu) and closing it had no animation: it popped in and out. It now rises out of its taskbar button and folds back into it, the system's minimise/restore animation. To open, it is shown minimised (the button comes back), then restored 60 ms later; to close, it is minimised, then hidden once the fold is over (400 ms), which takes the button off the taskbar as before. Reopened during the fold, the pending hide is dropped. Nothing is drawn by the page, and Windows' Animation effects setting turns it off like for any other window. Linux keeps the plain hide and show. All in hub_motion.rs; show_hub() and the close handler call open() and close().
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Coucou window is created hidden and only shown and hidden afterwards, so opening it (Settings in the island, the tray, the Start menu) and closing it have no animation: it pops in and out. This gives it Windows' own motion.
Changes (Windows)
hub_motion.rs(new): the window rises out of its taskbar button and folds back into it — the system's minimise/restore animation. To open: shown minimised (the button comes back), then restored 60 ms later. To close: minimised, then hidden once the fold is over (400 ms), which takes the button off the taskbar as before. Reopened during the fold, the pending hide is dropped; a click on the taskbar button during the fold leaves the window open.lib.rs:show_hub()and the close handler callhub_motion::open()/close().Validation
cargo test --workspace --locked: 516 passed, 4 ignored + 30 (hook).git diff --check: passed.To know: the taskbar button appears ~60 ms before the window rises (that is what the motion starts from), and opening takes a little longer than an instant show.
I know CLAUDE.md says existing views stay as they ship unless you ask, so this one is entirely your call — happy to adjust it, or to close it if it isn't the direction you want.