Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions .github/workflow/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
# Goal: Build the image for DevBoard Frontend and Push to Docker Hub, after linting the code
Comment thread
coderabbitai[bot] marked this conversation as resolved.
name: CI

on:
push:
branches: [master]

jobs:
code-lint:
runs-on: ubuntu-latest
steps:
- name: Checkout Code
uses: actions/checkout@v7

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 20
cache: "npm" # Automates dependency caching for faster builds

- name: Install Dependencies
run: npm install

- name: Run Lint (Biome)
run: npm run lint
Comment thread
coderabbitai[bot] marked this conversation as resolved.

build-and-push:
runs-on: ubuntu-latest
Comment on lines +27 to +28

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

# First, find the workflow file - note the comment mentions "workflow" but it's typically "workflows"
find .github -name "ci.yml" -o -name "*.yml" | head -20

Repository: LondheShubham153/devboard

Length of output: 93


🏁 Script executed:

cat -n .github/workflow/ci.yml

Repository: LondheShubham153/devboard

Length of output: 1420


Enforce lint-before-push with a job dependency.

build-and-push lacks a needs: code-lint dependency, allowing both jobs to run in parallel. The workflow's stated goal ("after linting the code") requires lint to succeed before building, yet the current configuration can publish an image even when lint fails.

Suggested fix
  build-and-push:
+   needs: code-lint
    runs-on: ubuntu-latest
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
build-and-push:
runs-on: ubuntu-latest
build-and-push:
needs: code-lint
runs-on: ubuntu-latest
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflow/ci.yml around lines 27 - 28, The build-and-push job is
missing a job dependency declaration that enforces the lint job must complete
successfully before the build begins. Add a needs field to the build-and-push
job configuration that references the code-lint job to ensure sequential
execution and prevent building when linting fails.

steps:
- name: Checkout code
uses: actions/checkout@v7

- name: Docker Setup [Login]
uses: docker/login-action@v4
with:
username: ${{ vars.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}

- name: Docker Build and Push
uses: docker/build-push-action@v7
with:
push: true
tags: ${{ vars.DOCKERHUB_USERNAME }}/devboard-fe-master:latest
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ name: CI

on:
push:
branches: [master]
branches: [advanced]

jobs:
frontend:
Expand Down
33 changes: 0 additions & 33 deletions .github/workflows/matrix.yml

This file was deleted.

3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ There's no login and no AI here on purpose. The whole point is to *see how the
pieces connect*.

---

# trigger k liye k liye he bhai
## What you need

- **Docker** (with Docker Compose, which comes with Docker Desktop).
Expand Down Expand Up @@ -224,3 +224,4 @@ The browser calls these as `/api/...`; the backend serves them at the root.
├── backend/ Go API (main.go + Dockerfile)
└── init/postgres/ schema + example data, loaded on first start
```
#sa
1 change: 1 addition & 0 deletions devboard
Submodule devboard added at 817f03