Update create_ec2.sh

[vanamumashankar]

Because of exit 1, the script terminates immediately and install_awscli will never run.

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of missing AWS CLI by enabling automatic installation attempt when the tool is not detected.

[coderabbitai]

📝 Walkthrough

Walkthrough

The check_awscli function in a shell script is refactored to use return 1 instead of exit 1 when AWS CLI is missing, allowing the caller to handle the failure with a fallback pattern rather than terminating the entire process.

Changes

AWS CLI Check Fallback Pattern

Layer / File(s)	Summary
Error handling in AWS CLI check day03/create_ec2.sh	check_awscli now returns non-zero status (return 1) when aws is not found instead of calling exit 1, enabling the caller's `check_awscli

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A shell script learns the gentle art of return,
No exit needed when lessons are to learn,
Return one, return zero—let the caller decide,
Fallbacks flourish where conditions collide! 🐰✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'Update create_ec2.sh' is vague and generic, using a non-descriptive term that fails to convey the specific change (fixing error handling in check_awscli function).	Consider using a more descriptive title like 'Fix check_awscli to enable install fallback' or 'Change check_awscli exit to return for proper error handling.'

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

day03/create_ec2.sh (1)

74-74: ⚡ Quick win

Consider re-verifying AWS CLI availability after installation.

After install_awscli runs, the script continues without confirming that AWS CLI is now accessible. While installation failures should be caught by set -e, this additional check would provide clearer error messaging if AWS CLI isn't in the PATH after installation.

🔍 Suggested verification pattern

-    check_awscli || install_awscli
+    if ! check_awscli; then
+        install_awscli
+        if ! check_awscli; then
+            echo "AWS CLI installation completed but aws command not found in PATH" >&2
+            exit 1
+        fi
+    fi

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@day03/create_ec2.sh` at line 74, After calling install_awscli when
check_awscli initially fails, re-run check_awscli immediately and exit with a
clear error message if it still fails; specifically modify the sequence around
the check_awscli and install_awscli invocation so that if install_awscli is
executed you call check_awscli again and, on failure, emit a descriptive error
(e.g., "AWS CLI not found after installation") and terminate, ensuring the
script does not continue without aws in PATH.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@day03/create_ec2.sh`:
- Line 74: After calling install_awscli when check_awscli initially fails,
re-run check_awscli immediately and exit with a clear error message if it still
fails; specifically modify the sequence around the check_awscli and
install_awscli invocation so that if install_awscli is executed you call
check_awscli again and, on failure, emit a descriptive error (e.g., "AWS CLI not
found after installation") and terminate, ensuring the script does not continue
without aws in PATH.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: de8a4c46-0184-41b5-9f0d-2543289bd8d5

📥 Commits

Reviewing files that changed from the base of the PR and between 6a9ecb5 and 380e162.

📒 Files selected for processing (1)

• day03/create_ec2.sh