Extract highlight match/trigger logic into Core HighlightEvaluator#643
Merged
Conversation
The highlight-match semantics lived only inside LogWindow and had been copy-pasted into HighlightBookmarkScanner (its own comment admitted "Replicates the logic from LogWindow.CheckHighlightEntryMatch"), so two copies had to be kept in sync by hand and the logic had no direct test surface. Add a pure LogExpert.Core HighlightEvaluator with IsMatch, FindMatchingEntries, and GetTriggerActions (returning a HighlightActions record struct). Route both consumers through it: - HighlightBookmarkScanner: delete its duplicated CheckHighlightEntryMatch, call HighlightEvaluator.IsMatch. - LogWindow: FindMatchingHighlightEntries becomes a thin lock-wrapper over the evaluator; GetHighlightActions and the private CheckHighlightEntryMatch are removed; GetHighlightEntryMatches and FindHighlightEntry use HighlightEvaluator.IsMatch. The evaluator reports the decision only; side effects (Audio Alert, Set Bookmark, Stop Tail) stay at the LogWindow call sites, "Audio Alert fires only on the tail trigger path" invariant remains structural and cannot leak onto the bulk/scanner/paint paths. 12 new tests pin match/find/action behavior plus the null-arg guards.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
…ogExperts/LogExpert into highlight-evaluator-extraction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The highlight-match semantics lived only inside LogWindow and had been copy-pasted into HighlightBookmarkScanner (its own comment admitted "Replicates the logic from LogWindow.CheckHighlightEntryMatch"), so two copies had to be kept in sync by hand and the logic had no direct test surface.
Add a pure LogExpert.Core HighlightEvaluator with IsMatch, FindMatchingEntries, and GetTriggerActions (returning a HighlightActions record struct). Route both consumers through it:
The evaluator reports the decision only; side effects (Audio Alert, Set Bookmark, Stop Tail) stay at the LogWindow call sites, "Audio Alert fires only on the tail trigger path" invariant remains structural and cannot leak onto the bulk/scanner/paint paths.
12 new tests pin match/find/action behavior plus the null-arg guards.