Lift char-block detachment onto the reader interface#641
Merged
Conversation
The LogfileReader read loop type-checked `reader is …System/…Direct` at three sites (six branches) to call DetachBlocks(), reaching through the ILogStreamReaderMemory seam to the concrete readers. Adding a reader meant editing every site, and the Legacy reader was silently skipped — its pooling allocator was never detached and never disposed, orphaning its rented blocks (a latent ArrayPool leak). Add DetachCharBlocks() to ILogStreamReaderMemory so the loop calls it unconditionally: - Direct: rename DetachBlocks() -> DetachCharBlocks(); drop the dead `BlockAllocator => null` shim. - System/Legacy: implement DetachCharBlocks() over their allocator and make BlockAllocator private — detachment is the only seam-crossing surface now. - Legacy: add the Dispose override System already had, closing the leak. - LogfileReader: six `is`-branches collapse to one DetachCharBlocks() call per site. Legacy now participates uniformly. Tests migrated off reader.BlockAllocator onto the public DetachCharBlocks() seam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LogfileReader read loop type-checked
reader is …System/…Directat three sites (six branches) to call DetachBlocks(), reaching through the ILogStreamReaderMemory seam to the concrete readers. Adding a reader meant editing every site, and the Legacy reader was silently skipped — its pooling allocator was never detached and never disposed, orphaning its rented blocks (a latent ArrayPool leak).Add DetachCharBlocks() to ILogStreamReaderMemory so the loop calls it unconditionally:
BlockAllocator => nullshim.is-branches collapse to one DetachCharBlocks() call per site. Legacy now participates uniformly.Tests migrated off reader.BlockAllocator onto the public DetachCharBlocks() seam.