fix: load header-fragment.js in main layout to enable nav dropdowns#448
Merged
Merged
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Contributor
|
Contributor
|
🚀 Starting production deploy of site header and footer fragments... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After the refactor in commit
8924435(unify Features dropdown with Solutions mechanism), the old Bootstrap-based dropdown JS was removed frommain.js. The new custom dropdown logic lives exclusively inheader-fragment.js, which is only loaded by external fragment consumers (e.g. WordPress) — not by the static site itself.As a result, the Solutions, Features, and language selector dropdowns stopped working on the static site.
Fix
Add
header-fragment.jsas a<script type="module">tag inmain.blade.php, alongside the existingmain.jstag. This is safe because:header-fragment.jsis already a separate Vite entry pointif (root) { ... }so it's a no-op if the header element is absentdata-fragment-js