Repository navigation
fix: agent task execution, MCP OAuth, sidebar gutters, and extension cards - #363
Merged
Merged
Conversation
Co-Authored-By: Divyansh (Dev) Lalwani <dslalwani@gmail.com>
Co-Authored-By: Divyansh (Dev) Lalwani <dslalwani@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Co-Authored-By: Divyansh (Dev) Lalwani <dslalwani@gmail.com>
Co-Authored-By: Divyansh (Dev) Lalwani <dslalwani@gmail.com>
Co-Authored-By: Divyansh (Dev) Lalwani <dslalwani@gmail.com>
Co-Authored-By: Divyansh (Dev) Lalwani <dslalwani@gmail.com>
devin-ai-integration
Bot
requested a review
from DevelopedByDev
as a code owner
November 1, 2026 22:26
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
# Conflicts: # CHANGELOG.md
Collaborator
|
Integration acceptance at
No blocking review findings remain. Proceeding with authorized local-owner merge, native Git production verification and canonical-main Convex sync. |
Collaborator
|
Release verified at
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
oauththrough MCP create/update and Test connection parsing instead of silently savingnone. Test connection now uses the stored OAuth session through the existing runtime auth provider. The user confirmed successful Monid authorization and agent tool calls; this follow-up addresses the separate connection-test failure.Risk and rollback
workItems.assignmentExecutionfield; no backfill. Old records remain readable and can prepare an assignment when explicitly reassigned. Backend and web must be deployed at matching revisions.Verification
Owner acceptance: the user confirmed "i tested, it works" after the MCP connection-test and compact-tab fixes, and requested ready-for-review status. This is user-reported acceptance, not an additional agent-run hosted test.
Follow-up
305aa5c: 10 focused MCP route/card tests, targeted ESLint, direct root TypeScript and diff checks passed. Regression tests exercise the real OAuth transport provider with stored credentials, ignore client-supplied tokens, and reject inaccessible servers. Network connection/tool listing is mocked. Local rendered checks confirm compact tabs on desktop/mobile and in dark mode. Final CI for this head: 22 passed, 0 failed, 0 pending; Paid Gateway Canary skipped. Required quality/security gates and PR Preview are green.Latest UI revision: 9 focused tests, changed-file ESLint, direct root TypeScript and diff checks passed. Final CI: 22 passed, 0 failed, 0 pending; Paid Gateway Canary skipped. Required quality/security gates and preview checks are green.
Rendered actual production components with app CSS in an isolated local fixture: light/dark, desktop/mobile, MCP auth/tool policy edits and save/connect/test callbacks, Skills save and Active, and delete cancel/confirm. Fixture callbacks do not contact real services.
Previous head CI settled: 22 passed, no failures or pending checks, Paid Gateway Canary skipped. Full suites, typecheck, lint, secret scan and required quality/security gates passed.
Focused Node suites passed; final WorkService suite: 12 passed. MCP create/update parser regression: 4 passed.
Convex Work suite: 39 passed. Resize unit test: 1 passed.
Changed-file ESLint: zero errors, one existing restricted-import warning. Shared-isomorphic and diff checks passed.
Local full typecheck hit desktop-shell/bridge fingerprint and manifest boundary checks; direct TypeScript check passed and CI full typecheck subsequently passed.
Preview evidence
305aa5cd9f196949da96743aab5b6790ea79cadb305aa5c. Local component evidence predates a behavior-preserving MCP footer extraction; hosted feature QA remains pending.d1c892e9e9c3051735b6ba728a330dcf5be7b493. Hosted feature QA of the new UI head remains pending.dpl_64SdcsFXPAazQyGZFa5swGZGDa3B, matching the prior OAuth verification head, not the latest UI revision. Preview controller validated isolatedpreview/pr-363; build logs and browser runtime both identifyhttps://industrious-viper-605.convex.cloud.No OAuth state was provided for this MCP authorization. Source tracing confirms discovery runs before interactive authorization has a state; it does not block Connect. This initial card warning remains.internal/plans/mockups/extension-cards-dialogs.html. Production components now implement this design.Current component rendering
Actual production components with app CSS and fixture data, not hosted backend QA:
Main changes automatically deploy to Vercel Production through Git integration.
Integration verifies the live SHA and affected behavior; backend changes also need
Convex synchronization from clean canonical main after matching web is live.
A successful preview build still needs feature QA.
Link to Devin session: https://app.devin.ai/sessions/725db300351b4894a3bc35d884db40fd
Open in Devin Desktop: https://app.devin.ai/desktop/session/725db300351b4894a3bc35d884db40fd?variant=devin
Requested by: @DevelopedByDev
Follow-up compact tabs
Local production-component rendering: