Fix flagged security vulnerabilities - #69
Merged
Merged
Conversation
…eracode SCA flaws Fixes TFS bugs #675523, #689896, #689897, #689898, #689899, #689900: - js-yaml 4.1.1 -> 4.3.0 (CVE-2026-53550, CVE-2026-59869): backports the default-on maxTotalMergeKeys cap that bounds YAML merge-key (<<) processing - brace-expansion 2.1.1 -> 2.1.3 (CVE-2026-14257, CVE-2026-13149): bounds total expansion output length and removes the recursive post-expansion that caused exponential-time blowup on chained brace groups - fast-uri 3.1.2 -> 3.1.4 (CVE-2026-16221, CVE-2026-13676): fixes backslash authority-delimiter and IDN hostname canonicalization desync vs Node's URL All three stay within the major versions already required by eslint/ajv, so no override needed beyond bumping the pinned/floor version. Verified via a full workspace build and the lf-js-utils unit suite (362/362 passing). TFS bug #689901 (linkify-it CVE-2026-59887) is intentionally not included: the only fix ships in linkify-it 6.x, which breaks markdown-it 14.x's usage of it (named export vs. the callable default export markdown-it expects). markdown-it hasn't adopted linkify-it 6.x in any released 14.x version. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…#689901)
Fixes TFS bug #689901. Prior investigation assumed the only fix was
linkify-it 6.x, which breaks markdown-it's usage (named export vs. the
callable default export markdown-it expects). Re-checked and found the
CVE is actually already fixed in linkify-it 5.0.2 (verified in source:
src_email_name's local-part is now bounded to {0,63} chars, matching the
CVE's suggested RFC 5321 remediation, and the mailto validator otherwise
unchanged) - no need for the breaking 6.x jump.
5.0.2 keeps the same `module.exports = LinkifyIt` CommonJS shape, and
satisfies markdown-it 14.2.0's own `^5.0.1` requirement, so no override
conflicts. Verified via a full workspace build, `npm run generate-docs`
end-to-end (0 errors), and the lf-js-utils unit suite (362/362 passing).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
quinn-mchale-lf
approved these changes
Jul 30, 2026
added 2 commits
July 30, 2026 07:52
bzajzon-laserfiche
approved these changes
Jul 30, 2026
bzajzon-laserfiche
left a comment
bzajzon-laserfiche
left a comment
Contributor
There was a problem hiding this comment.
Approved. Security dependency bump only — pnpm overrides for brace-expansion, js-yaml, fast-uri, linkify-it, and ajv's fast-uri bumped to patched versions to clear flagged Veracode SCA vulnerabilities. No source changes; all CI checks (CodeQL, build, tests) pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.