Skip to content

Fix/puk wind dmg on windsday should still gives TP even if the dmg is absorbed. #9994

Open
Lydya-nick77 wants to merge 1 commit into
LandSandBoat:basefrom
Lydya-nick77:fix/puk-windsday-absorb-tp
Open

Fix/puk wind dmg on windsday should still gives TP even if the dmg is absorbed. #9994
Lydya-nick77 wants to merge 1 commit into
LandSandBoat:basefrom
Lydya-nick77:fix/puk-windsday-absorb-tp

Conversation

@Lydya-nick77

Copy link
Copy Markdown

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

This PR fixes the behavior of the Puk family. On Windsday, when we cast a wind dmg spell on a Puk, the enemy should gain 1000 TP. Because Puks absorb wind damage, they were not gaining the TP.
Capture: https://www.youtube.com/watch?v=VKB-Zz8PYqw

Adjusted the Puk.lua family file.

Steps to test these changes

Cast aero on a puk during windsday. Check the mob's TP
Also Tested with Garuda BP Aero II

@Lydya-nick77 Lydya-nick77 force-pushed the fix/puk-windsday-absorb-tp branch from 684af03 to 1726bfc Compare May 8, 2026 21:42
puk:getMod(xi.mod.WIND_ABSORB) > 0 and
damageType == xi.damageType.WIND
)
then

@Xaver-DaRed Xaver-DaRed May 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think this is fixing anything.
Firstly, the new check is
x or (x and y and z) making y and z never enforced.
(damageType == elementTable[VanadielDayOfTheWeek()] is equivalent to VanadielDayOfTheWeek() == xi.day.WINDSDAY and damageType == xi.damageType.WIND when it comes to wind damage)

Secondly, the old method doesnt care for damage amount, at all.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in my last commit, my bad

@Lydya-nick77

Copy link
Copy Markdown
Author

it's working as intended now, my bad

@Xaver-DaRed Xaver-DaRed added the squash Reminder to squash commits before/on merge (you can do this, or maintainers will do this for you) label May 9, 2026
@Lydya-nick77 Lydya-nick77 force-pushed the fix/puk-windsday-absorb-tp branch from 214c5e5 to 9dc3a32 Compare May 9, 2026 12:08
@Lydya-nick77 Lydya-nick77 requested a review from Xaver-DaRed May 9, 2026 13:10
@github-actions

Copy link
Copy Markdown

This PR has been automatically marked as stale because
it has not had recent activity. It will be closed if no
further activity occurs.

@github-actions github-actions Bot added the stale label May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

squash Reminder to squash commits before/on merge (you can do this, or maintainers will do this for you) stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants