Fix/puk wind dmg on windsday should still gives TP even if the dmg is absorbed. #9994
Open
Lydya-nick77 wants to merge 1 commit into
Open
Fix/puk wind dmg on windsday should still gives TP even if the dmg is absorbed. #9994Lydya-nick77 wants to merge 1 commit into
Lydya-nick77 wants to merge 1 commit into
Conversation
684af03 to
1726bfc
Compare
Xaver-DaRed
reviewed
May 8, 2026
| puk:getMod(xi.mod.WIND_ABSORB) > 0 and | ||
| damageType == xi.damageType.WIND | ||
| ) | ||
| then |
Contributor
There was a problem hiding this comment.
I dont think this is fixing anything.
Firstly, the new check is
x or (x and y and z) making y and z never enforced.
(damageType == elementTable[VanadielDayOfTheWeek()] is equivalent to VanadielDayOfTheWeek() == xi.day.WINDSDAY and damageType == xi.damageType.WIND when it comes to wind damage)
Secondly, the old method doesnt care for damage amount, at all.
Author
There was a problem hiding this comment.
fixed in my last commit, my bad
Author
|
it's working as intended now, my bad |
214c5e5 to
9dc3a32
Compare
|
This PR has been automatically marked as stale because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
This PR fixes the behavior of the Puk family. On Windsday, when we cast a wind dmg spell on a Puk, the enemy should gain 1000 TP. Because Puks absorb wind damage, they were not gaining the TP.
Capture: https://www.youtube.com/watch?v=VKB-Zz8PYqw
Adjusted the Puk.lua family file.
Steps to test these changes
Cast aero on a puk during windsday. Check the mob's TP
Also Tested with Garuda BP Aero II