Skip to content

[core] [C++] [lua] Update Automaton Steam Jacket#10257

Open
Skold177 wants to merge 1 commit into
LandSandBoat:basefrom
Skold177:Steam-Jacket
Open

[core] [C++] [lua] Update Automaton Steam Jacket#10257
Skold177 wants to merge 1 commit into
LandSandBoat:basefrom
Skold177:Steam-Jacket

Conversation

@Skold177

@Skold177 Skold177 commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Fixes handling of the automaton attachment Steam Jacket. Old code was having Steam Jacket checked in physical damage when it is not supposed to apply, offering up to 80% reduced damage on normal physical attacks. Steam Jacket, as noted by both BG Wiki & the JP Wiki should only apply to elemental damage types. The damage type gets changed if its hit with a new type of damage, but physical damage types don't change it.

https://www.bg-wiki.com/ffxi/Steam_Jacket
https://wiki.ffo.jp/html/15352.html

  • Added a new utility for Steam Jacket in combat utils, this is used for MobMagicalMove, MobBreathMove & Damage_Spell.lua

  • Adjusted the code in battleutils to only work for elemental damage types, and removed it from the physical and ranged sections. Now only used in the magical portion. (this will catch other types of magic damage, like spikes or skillchains.)

Steps to test these changes

Equip Steam Jacket, try some mobskills and spells (like Diamond Dust -> Blizzard V) see damage reduction works against different damage sources.

@Skold177 Skold177 changed the title [core] [C++] [Update Automaton Steam Jacket [core] [C++] [lua] [Update Automaton Steam Jacket Jun 7, 2026
@Skold177 Skold177 changed the title [core] [C++] [lua] [Update Automaton Steam Jacket [core] [C++] [lua] Update Automaton Steam Jacket Jun 7, 2026
Comment thread src/map/modifier.h
Comment thread src/map/utils/battleutils.cpp Outdated
Comment thread scripts/utils/combat_utils.lua Outdated
@Xaver-DaRed Xaver-DaRed added the hold On hold, pending further action/info label Jun 8, 2026
@Xaver-DaRed Xaver-DaRed force-pushed the Steam-Jacket branch 2 times, most recently from c9ec2b5 to 92ef642 Compare June 9, 2026 10:13
@Xaver-DaRed Xaver-DaRed removed the hold On hold, pending further action/info label Jun 9, 2026
Co-authored-by: Xaver-DaRed <Xaver-DaRed@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants