[core] [C++] [lua] Update Automaton Steam Jacket#10257
Open
Skold177 wants to merge 1 commit into
Open
Conversation
Xaver-DaRed
reviewed
Jun 8, 2026
Xaver-DaRed
reviewed
Jun 8, 2026
Xaver-DaRed
reviewed
Jun 8, 2026
c9ec2b5 to
92ef642
Compare
Co-authored-by: Xaver-DaRed <Xaver-DaRed@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Fixes handling of the automaton attachment Steam Jacket. Old code was having Steam Jacket checked in physical damage when it is not supposed to apply, offering up to 80% reduced damage on normal physical attacks. Steam Jacket, as noted by both BG Wiki & the JP Wiki should only apply to elemental damage types. The damage type gets changed if its hit with a new type of damage, but physical damage types don't change it.
https://www.bg-wiki.com/ffxi/Steam_Jacket
https://wiki.ffo.jp/html/15352.html
Added a new utility for Steam Jacket in combat utils, this is used for MobMagicalMove, MobBreathMove & Damage_Spell.lua
Adjusted the code in battleutils to only work for elemental damage types, and removed it from the physical and ranged sections. Now only used in the magical portion. (this will catch other types of magic damage, like spikes or skillchains.)
Steps to test these changes
Equip Steam Jacket, try some mobskills and spells (like Diamond Dust -> Blizzard V) see damage reduction works against different damage sources.