feat: DoubleEndedIterator for Iter on Arena.#43
Open
dannyhammer wants to merge 1 commit into
Open
Conversation
Implementation of `DoubleEndedIterator`trait on the `Iter` type for `Arena`, including two additional unit tests `iter_rev()` and `iter_both_directions()` in `iter/iters.rs` to confirm expected behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of
DoubleEndedIteratortrait on theItertype forArena, including two additional unit testsiter_rev()anditer_both_directions()initer/iter.rsto confirm expected behavior.I'm using
thunderdomein another project, and I found myself needing to doarena.iter().collect::<Vec<_>>().into_par_iter().rev(), which is disgusting and not optimal. I looked into the iterator forArenaand saw that it was using aslice::Iterinternally, which implementsDoubleEndedIterator, so I made some additions and wrote some tests to confirm it works.I hope the code aligns with your methodology. Given that
arena.iter()doesn't define an explicit order, I see no reason why "backwards iteration" would yield undesirable outcomes. I am unsure if the check forself.slot > self.lenonnext()andnext_back()is strictly necessary, but it felt appropriate to include.