Implement optional type for Index#39
Open
tyler274 wants to merge 7 commits into
Open
Conversation
Open
Author
|
Removed the trait bounds mentioned, The tests still need some explicit type declaration though. |
Author
|
Implemented or derived |
Owner
|
Hi, thanks for the PR! This is really awesome. I wonder if there's anything we can do about the new inference issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of #16 (comment)
It passes all the tests,
but I would highly suggest double checking I didn't mess up anything with the trait bounds on.Ilittered all over the itersI also had to edit a lot of tests to be explicit about the Arena typing, and I'm not sure if its a breaking change backwards compatibility wise.