RPM spec minor fixes#112
Open
mavit wants to merge 9 commits into
Open
Conversation
…pt /etc/logrotate.d/lyrionmusicserver” Signed-off-by: Peter Oliver <git@mavit.org.uk>
``` lyrionmusicserver.noarch: W: obsolete-not-provided SliMP3 lyrionmusicserver.noarch: W: obsolete-not-provided logitechmediaserver lyrionmusicserver.noarch: W: obsolete-not-provided slimserver lyrionmusicserver.noarch: W: obsolete-not-provided squeezeboxserver lyrionmusicserver.noarch: W: obsolete-not-provided squeezecenter ``` Signed-off-by: Peter Oliver <git@mavit.org.uk>
Signed-off-by: Peter Oliver <git@mavit.org.uk>
It’s not referenced anywhere. Signed-off-by: Peter Oliver <git@mavit.org.uk>
Signed-off-by: Peter Oliver <git@mavit.org.uk>
Fixes the following warning from `rpmlint`: ``` lyrionmusicserver.spec: E: superfluous-%clean-section ``` Signed-off-by: Peter Oliver <git@mavit.org.uk>
Fixes the following `rpmlint` warning:
```
lyrionmusicserver.spec:402: W: macro-in-comment %{shortname}
```
Signed-off-by: Peter Oliver <git@mavit.org.uk>
… RPM
Fixes the following warnings from `rpmbuild`:
```
absolute symlink: /etc/lyrionmusicserver/server.conf -> /var/lib/lyrionmusicserver/prefs/server.prefs
absolute symlink: /usr/share/lyrionmusicserver/Plugins -> /var/lib/lyrionmusicserver/Plugins
```
Signed-off-by: Peter Oliver <git@mavit.org.uk>
Member
|
Adding @JohanSaaw as another expert eye - thanks! |
Fixes the following warning from `rpmbuild`: ``` *** WARNING: ./etc/sysconfig/lyrionmusicserver is executable but has no shebang, removing executable bit ``` Signed-off-by: Peter Oliver <git@mavit.org.uk>
Member
|
Could you please sync this PR with the |
Contributor
|
Hi, I was away, so I did not check github for some time. If there still is a need, I'll be happy to look at the RPM spec file. |
JohanSaaw
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are a bunch of minor changes that fix warning or errors from
rpmlintorrpmbuild.