Repository navigation
fix: preserve queue compatibility and classify admission rejects - #50
Merged
Merged
Conversation
Signed-off-by: David <12414531+DavidBellamy@users.noreply.github.com>
Signed-off-by: David <12414531+DavidBellamy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
Two compatibility issues block a safe SMG artifact refresh:
internal_error. Under saturation this makes normal backpressure look like a large internal failure storm.Closes #48.
Closes #49.
Solution
admission_rejectedgRPC error label.max_queued_requests_per_tenantoptional. When omitted, it inherits the partition's existing shared queue budget and therefore preserves prior behavior. Explicit positive limits remain supported and zero remains invalid.Neither change alters adaptive admission decisions, response status codes, fair-share ordering, or engine behavior.
Changes
admission_rejectedrouter metric label and status mapping.Test Plan
cargo +nightly fmt --all -- --checkcargo test --offline -p smg --lib --quiet -- --test-threads=1cargo clippy --offline -p smg --lib --no-deps -- -D warnings -A clippy::ignored-unit-patternscargo check --offline --manifest-path bindings/python/Cargo.tomlChecklist
cargo +nightly fmtpassescargo clippypasses with the documented pre-existing ignored-unit-patterns allowance