Repository navigation
Conversation
Signed-off-by: Micah Villmow <4211002+mvillmow@users.noreply.github.com>
Signed-off-by: Micah Villmow <4211002+mvillmow@users.noreply.github.com>
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A native MoVA FP8 model must reject a second source load after a successful presharded restore. The restore path previously left its initial-load flag unset. A later load could read input tensors before it failed.
Related issue: #50. Its wider acceptance criteria stay open.
Modifications
mark_load_complete()method. The presharded loader calls this method after it restores tensors and verifies the checksum.Public model reference: IFM/K2-Horizon-MoVA-FP8.
The positive test uses synthetic tensors and explicit synthetic router provenance. It does not supply the missing router provenance for the public checkpoint.
Head:
adabb14a39ab514277e9714cb8e4d7c726bd3982. This change depends on PR #52 at3d6db36e46f5f15643a642e92f97ef2fb750a56a. The comparison has 143 additions, no deletions, and two files.Accuracy Tests
2f4fc5b02e3be5cfc59fec8499434b11093ad78badabb14a39ab514277e9714cb8e4d7c726bd3982Ordinary Lint passed at the current head. The PR test gate failed because the required
run-cilabel is missing. Ordinary PR checks are not all successful.No local tests were run. These CPU results do not establish full-checkpoint accuracy or GPU qualification.
Speed Tests and Profiling
No speed benchmark was run. Full-checkpoint and H200 qualification stay in the linked issue.
Checklist