Repository navigation
fix(deployment): check Kubernetes tools in preflight - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kubernetes preflight could report a host ready when Docker was present but kubectl and Helm were missing. Select prerequisites from the deployment mode or validated named environment, and require bounded client-only kubectl and Helm probes for the Kubernetes chart path. Unknown or malformed profiles fail closed.
Preserve the existing report format and non-Kubernetes checks. Successful tool probes explicitly leave cluster access and first boot unverified.
Validation: the regression file fails on the unchanged base (29 failed, 8 passed); the repaired preflight and adjacent profile-validation suites pass all 71 tests. After ordinary integration of main e9d9929, strict docs, combined preflight/Helm tests, and normal commit/push hooks pass with both reviewed files unchanged. Earlier all-files gates and full hosted CI passed at 79560ab. Current-head hosted CI passed gates, scanner quality, and wheel build at https://github.com/Knuckles-Team/graph-os/actions/runs/37174546666 for commit 7694c6e.