Repository navigation
test: verify sync client teardown by owned resources - #73
Merged
Merged
Conversation
Knucklessg1
marked this pull request as ready for review
October 8, 2026 03:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The successful synchronous-client close test compared process-wide descriptor, socket, selector and thread totals. Unrelated event-loop cleanup could therefore fail an otherwise correct teardown; this caused the root Python job failure in run 37716787573.
Assert that each client's owned loop is closed and its thread has terminated. Keep the 32 repeated-connect/close cycles and exactly-once transport-close assertion. The retry test now proves its thread remains alive after the deliberately failed first stop and terminates after retry. Remove the unused process-count helper and obsolete Linux-only skips; these checks use portable owned objects.
The successful-close test deliberately closes an unrelated event loop during its first cycle, with subsequent cycles exercising stable-resource repeated close. This extends EG-CONTRACT-R021's owned-resource proof to the successful/retried close paths; no whole-spec or release acceptance is claimed.
Validation against b4e272d:
Only tests/test_sync_client_lifecycle.py changes. No test suppression, hook bypass, native/release gate change or deployment. Merge remains parent-coordinated; run 37716787573 is FAILED, not qualified. Privacy PR71 is unchanged.