alkalinity: add definition based on weak acids and bases - #398
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #398 +/- ##
==========================================
+ Coverage 86.21% 86.24% +0.02%
==========================================
Files 14 14
Lines 1842 1846 +4
Branches 319 320 +1
==========================================
+ Hits 1588 1592 +4
Misses 209 209
Partials 45 45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @rkingsbury , this branch is ready for review. I realized there is a |
rkingsbury
left a comment
There was a problem hiding this comment.
Nice contribution @SuixiongTay , thank you! See comments.
In addition to what you have here, please add a test case or two to the existing test_alkalinity_hardness method. These cases should not use equilibrate. Rather, just define some solutions with known compositions (ideally, use one that contains weak acid species other than carbonate) and test the returned value against your manually calculated one.
|
Hi @rkingsbury , the PR has been updated and is ready for your review. Thanks! |
rkingsbury
left a comment
There was a problem hiding this comment.
Looks good @SuixiongTay . Ready to merge after a few small text edits.
Summary
Added additional acid and bases including:
This PR addresses #299 .
Todos