-
Notifications
You must be signed in to change notification settings - Fork 27
Migrate Pourbaix workflow to pyEQL v1.6.1
#369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: pourbaix
Are you sure you want to change the base?
Changes from all commits
792836c
4251c17
4b2738e
4daa926
796ba6e
0ffddb6
9db4cee
70cc41c
77ecc97
ca527b2
e75c4ee
e6a0b5b
af0a1c5
83d20e2
80bc9de
6a2bb69
81760ba
b8c443d
ed5b509
8df06bb
8184ea6
9d28efd
8218d01
b112ebe
e41b444
372113a
afae428
2ef7023
c382044
1eecf31
cac3a62
8bdd5ff
2842f3e
181c30d
cec9e3f
7ddf161
b24e126
dc08dd2
5619c01
35f2292
4ee26d2
fbad4c1
0f02f95
4e4a5d5
7614897
b5c65a1
3f1b4af
01f253d
dccd6f5
b1a368e
42b859b
a000971
9aae99a
dfb992f
6991929
ce8d00c
232ef74
67dfb38
9c21c5d
77e9098
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Both notebooks look good! In this one, please add a short explanatory comment near the examples to explain why, in Example 1, you set |
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,8 +46,16 @@ testing = [ | |
| "mypy>1", | ||
| "ruff>0.0.100", | ||
| "tox<4", | ||
| "openpyxl", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think |
||
| ] | ||
| pourbaix = [ | ||
| "mp-api>=0.45.0", | ||
| ] | ||
| docs = [ | ||
| "sphinx>=3.2.1", | ||
| "sphinx-rtd-theme", | ||
| "myst-parser[linkify]", | ||
| ] | ||
| docs = ["sphinx>=3.2.1", "sphinx-rtd-theme", "myst-parser[linkify]"] | ||
| full = ["rich"] | ||
|
|
||
| [build-system] | ||
|
|
@@ -182,5 +190,5 @@ enable_error_code = ["ignore-without-code", "redundant-expr", "truthy-bool"] | |
| warn_unreachable = true | ||
|
|
||
| [tool.codespell] | ||
| ignore-words-list = "nd,formate,Te,CaCl,CaF,ore" | ||
| ignore-words-list = "nd,formate,Te,CaCl,CaF,ore, teh,hte,hsi" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Where are |
||
| skip = "tests/test_files/*,src/pyEQL/database/*" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please revert this change to whatever the upstream branch has, unless this bump is required to make your changes work (this requirement will be updated separately elsewhere) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| Name: MIT | ||
| Advanced: | ||
| UCorrections: | ||
| O: #Based on burp version as of Feb 28 2011 | ||
| Mn: -1.687 | ||
| Fe: -1.723 | ||
| Co: -1.751 | ||
| Cr: -2.067 | ||
| Mo: -3.531 # refit number. | ||
| W: -2.762 | ||
| V: -1.764 | ||
| Ni: -2.164 | ||
| Nb: -1.259 | ||
| Re: -1.177 | ||
| Cu: -1.156 | ||
| Ag: -0.324 | ||
| Ta: -1.027 #Adjusted correction for Ta. Shyue May 24 2012 | ||
| F: #Based on burp version as of Feb 28 2011 | ||
| Mn: -1.687 | ||
| Fe: -1.723 | ||
| Co: -1.751 | ||
| Cr: -2.067 | ||
| Mo: -3.531 # refit number. | ||
| W: -2.762 | ||
| V: -1.764 | ||
| Ni: -2.164 | ||
| Nb: -1.259 | ||
| Re: -1.177 | ||
| Cu: -1.156 | ||
| Ag: -0.324 | ||
| Ta: -1.027 #Adjusted correction for Ta. Shyue May 24 2012 | ||
| S: #Based on burp version as of Feb 28 2011 | ||
| Mn: -1.232 | ||
| Fe: -1.113 | ||
|
|
||
| #Fit energies for elements. Note that these must be energies per atom! | ||
| #Document the fits PROPERLY. Fits by default are done over all alkali, alkali earth, and Al. | ||
| #The whole set is ("Li", "Na","K","Rb", "Cs", "Mg", "Ca","Sr", "Ba","Al") | ||
| #Last update: Sep 13 2011 by Shyue Ping Ong | ||
| CompoundEnergies: | ||
| #O2: -4.25915626315 | ||
| N2: -8.00185429481 | ||
| F2: -1.42203822397 | ||
| Cl2: -1.26486611357 | ||
| H2: -3.302 | ||
| SO3: -6.16649882299 #Sulfur corrections as of Jun 18 2014 | ||
| SO2: -6.08728347651 | ||
|
|
||
| OxideCorrections: | ||
| oxide: -0.66975 | ||
| peroxide: -0.44317 #Corrections fit to Li2O2, Na2O2, K2O2, SrO2 | ||
| superoxide: -0.13893 #Superoxide Corrections fit to CsO2, NaO2, KO2 | ||
| ozonide: 0.00 | ||
|
|
||
| # Entropic Correction term for gases. | ||
| # For H2O, energy is corrected such that the experimental formation energy of water of -2.46 eV is reproduced. | ||
| # H2 is corrected such that the experimental formation energy of water is reproduced. | ||
| AqueousCompoundEnergies: | ||
| O2: -0.316731 | ||
| N2: -0.295729 | ||
| F2: -0.313025 | ||
| Cl2: -0.344373 | ||
| Br: -0.235039 | ||
| Hg: -0.234421 | ||
| H2: -3.6018845 | ||
| H2O: -4.972 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| Name: MP | ||
| Advanced: | ||
| UCorrections: | ||
| O: | ||
| Mn: -1.68085015096 #Fit to MnO, Mn3O4 and MnO2 (BURP:-1.687) | ||
| Fe: -2.733 #Fit to FeO and Fe2O3 (Fe3O4 probably wrong) | ||
| Co: -1.874 #Fit to cobalt monoxide, Co3O4 (BURP:-1.751) | ||
| Cr: -2.013 #Fit to Cr2O3 (CrO3 missing) (BURP: -2.067) | ||
| Mo: -3.531 #Fit to MoO3 and MoO2 (BURP: -2.668) | ||
| W: -4.351 #Fit to WO2 and WO3 (BURP: -2.762) | ||
| V: -1.682 #Fit to V2O3 and V2O5 (VO2 fit is way off) (BURP: -1.764) | ||
| Ni: -2.164 #Based on burp version as of Feb 28 2011 | ||
| F: | ||
| Mn: -1.68085015096 #Fit to MnO, Mn3O4 and MnO2 (BURP:-1.687) | ||
| Fe: -2.733 #Fit to FeO and Fe2O3 (Fe3O4 probably wrong) | ||
| Co: -1.874 #Fit to cobalt monoxide, Co3O4 (BURP:-1.751) | ||
| Cr: -2.013 #Fit to Cr2O3 (CrO3 missing) (BURP: -2.067) | ||
| Mo: -3.531 #Fit to MoO3 and MoO2 (BURP: -2.668) | ||
| W: -4.351 #Fit to WO2 and WO3 (BURP: -2.762) | ||
| V: -1.682 #Fit to V2O3 and V2O5 (VO2 fit is way off) (BURP: -1.764) | ||
| Ni: -2.164 #Based on burp version as of Feb 28 2011 | ||
|
|
||
| #Fit energies for elements. Note that these must be energies per atom! | ||
| #Document the fits PROPERLY. Fits by default are done over all alkali, alkali earth, and Al. | ||
| #The whole set is ("Li", "Na","K","Rb", "Cs", "Mg", "Ca","Sr", "Ba","Al") | ||
| #Last update: Sep 13 2011 by Shyue Ping Ong | ||
| CompoundEnergies: | ||
| #O2: -4.22986844926 #Fit to all except Cs, which is a serious outlier | ||
| N2: -7.95247218762 #Fit to Li3N, Mg3N2, Ca3N2, AlN | ||
| F2: -1.42055013381 #Fit to all. | ||
| Cl2: -1.25385097674 #Fit to all except AlCl3, which is not present in the database. | ||
| H2: -3.23973666138 | ||
|
|
||
|
|
||
| OxideCorrections: | ||
| oxide: -0.70229 #Oxide Corrections fit to Li2O, Na2O, K2O, Rb2O, MgO, CaO, SrO, BaO, Al2O3 on 09/18 | ||
| peroxide: -0.46622 #Peroxide Corrections fit to Li2O2, Na2O2, K2O2, SrO2 on 09/18 | ||
| superoxide: -0.14598 #Superoxide Corrections fit to CsO2, NaO2, KO2 on 09/18 | ||
| ozonide: 0.00 | ||
|
|
||
|
|
||
| SulfideCorrections: | ||
| sulfide: -0.66346 #Sulfide Correction fit to Li2S, Na2S, K2S, Rb2S, CsS, MgS, CaS, BaS, Al2S3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please delete the checkpoint file (and/or edit
.gitignoreto correctly ignore them - this is actually a problem right now.(btw, the checkpoint file exposed your MP API Key, so you might want to re-generate it)