Skip to content

ci(setup): add local setup smoke workflow#3772

Open
RSO wants to merge 13 commits into
mainfrom
star-politician
Open

ci(setup): add local setup smoke workflow#3772
RSO wants to merge 13 commits into
mainfrom
star-politician

Conversation

@RSO
Copy link
Copy Markdown
Contributor

@RSO RSO commented Jun 5, 2026

Summary

  • Add a standalone setup-smoke workflow that exercises the documented clean-checkout local setup path on PRs and manual dispatch.
  • Add non-interactive dev:setup-env --ci placeholder env generation plus dev:start --no-attach for headless CI startup.
  • Add a dedicated Playwright setup-smoke test that signs in through fake auth and verifies the profile page against the running dev stack.

Verification

N/A - this PR introduces a CI setup smoke workflow; the workflow itself performs the browser validation.

Visual Changes

N/A

Reviewer Notes

The workflow currently runs on PRs for validation and can be switched to scheduled-only once it proves stable.

Comment thread apps/web/tests/setup-smoke/profile.spec.ts
@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented Jun 5, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Incremental review of the latest commit (fix(ci): assert visible setup smoke profile content) finds no new issues. The single change replaces the stale heading[Profile] assertion with two more-specific checks — link[Your Profile] and button[Edit profile] — that match the actual rendered profile page. The previously flagged WARNING on profile.spec.ts:46 is in unchanged code and is carried forward.

Files Reviewed (1 file changed, 10 files carried forward)
  • apps/web/tests/setup-smoke/profile.spec.ts — 1 carried-forward WARNING (existing inline comment on line 46)
  • .github/workflows/setup-smoke.yml — no issues (carried forward)
  • apps/web/package.json — no issues (carried forward)
  • apps/web/playwright.setup-smoke.config.ts — no issues (carried forward)
  • apps/web/src/lib/stripe-client.ts — no issues (carried forward)
  • dev/local/cli.ts — no issues (carried forward)
  • dev/local/runner.ts — no issues (carried forward)
  • dev/local/setup-env.ts — no issues (carried forward)
  • dev/local/tmux.ts — no issues (carried forward)
  • package.json — no issues (carried forward)

Reviewed by claude-4.6-sonnet-20260217 · 267,079 tokens

Review guidance: REVIEW.md from base branch main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant