fix: distribution precompile 32-byte withdraw address inflates native…

[mattkii]

Description

Fixes the distribution-precompile 32-byte withdraw address supply-inflation bug. When a balance event's account is not exactly 20 bytes (e.g. a 32-byte bech32 withdraw, module, or CosmWasm contract account), common.BytesToAddress truncates it to the trailing 20 bytes, causing the StateDB commit to mint a duplicate balance and inflate native supply.

AfterBalanceChange now skips mirroring any non-20-byte account (isMirrorableEVMAddress guard) in the CoinSpent, CoinReceived, and FractionalBalanceChange cases, so only bijective SDK↔EVM accounts are mirrored.

Most critical to review: precompiles/common/balance_handler.go

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• tackled an existing issue or discussed with a team member
• left instructions on how to review the changes
• targeted the main branch — N/A: targets feat/v0.6.0 (the v0.6.0-fork.1 release lineage kiichain pins); a v0.6.0-fork.2 tag will follow

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0a7109b5-faea-4962-93fb-ddd855bdc0f8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/distribution-32byte-withdraw

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Fixes a native-supply inflation bug in the distribution precompile’s balance mirroring by ensuring only SDK accounts with a bijective 20-byte EVM mapping are mirrored into the EVM StateDB.

Changes:

• Add an isMirrorableEVMAddress guard to skip mirroring balance events for non-20-byte SDK addresses (prevents common.BytesToAddress truncation collisions).
• Add a regression test covering the 32-byte address mirroring case.
• Update system/solidity test infrastructure (systemtest helper usage, consensus-timeout defaults, truffle/solc configuration, and a targeted test skip).

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/systemtests/upgrade_test.go	Updates systemtest helper invocation for awaiting upgrade height.
tests/systemtests/suite/test_suite.go	Ensures ModifyConsensusTimeout uses default node args when none are provided.
tests/systemtests/mempool/test_replacement.go	Skips a known-flaky DynamicFeeTx replacement scenario across nodes.
tests/systemtests/mempool/test_broadcast.go	Changes per-case setup in tx broadcasting tests (removes prior “no blocks produced” assertion).
tests/solidity/suites/opcode/truffle-config.js	Pins solc to a local soljson.js path for deterministic compilation.
tests/solidity/suites/opcode/package.json	Adds solc@0.5.17 for the opcode suite.
tests/solidity/suites/exception/truffle-config.js	Pins solc to a local soljson.js path.
tests/solidity/suites/eip1559/truffle-config.js	Pins solc to a local soljson.js path.
tests/solidity/suites/basic/truffle-config.js	Pins solc to a local soljson.js path.
tests/solidity/package.json	Adds solc@0.8.18 to the solidity test harness dependencies.
precompiles/common/balance_handler.go	Skips mirroring for non-20-byte SDK addresses to prevent truncated-address duplication in EVM state.
precompiles/common/balance_handler_test.go	Adds a regression test for skipping 32-byte address mirroring.
Makefile	Updates the legacy binary build checkout ref used by system tests.
CHANGELOG.md	Documents the bug fix in the changelog.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

The base branch was changed.