Add support for generation of varcond documentation - #3977
Open
wadoon wants to merge 7 commits into
Open
Conversation
Member
Author
|
We might want to discuss whether we want to introduce this library https://github.com/dnault/therapi-runtime-javadoc Which brings annotations and an annotation processor that writes annotations capturing the Javadoc to |
wadoon
force-pushed
the
weigl/varconddoc
branch
from
August 21, 2026 16:11
c868aae to
c23e0d6
Compare
wadoon
force-pushed
the
weigl/varconddoc
branch
from
August 21, 2026 16:16
c23e0d6 to
1ad9db8
Compare
unp1
requested changes
Aug 22, 2026
unp1
reviewed
Aug 22, 2026
wadoon
force-pushed
the
weigl/varconddoc
branch
from
August 22, 2026 21:21
1ad9db8 to
373f1ed
Compare
wadoon
force-pushed
the
weigl/varconddoc
branch
from
August 23, 2026 18:49
373f1ed to
bbdd443
Compare
unp1
requested changes
Aug 23, 2026
unp1
left a comment
Member
There was a problem hiding this comment.
Thanks! Concerning the failing WD test, that constructor for ConstantCondition takes a JAbstractSortedOperator which is not a parseable variable.
(also "\reference" does not take a variable)
| } | ||
| }; | ||
| public static final AbstractConditionBuilder ENUM_TYPE = | ||
| new ConstructorBasedBuilder("reference", EnumTypeCondition.class, SV, SV, SV); |
Member
There was a problem hiding this comment.
EnumTypeCondition declares only two parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended Change
Let class
de.uka.ilkd.key.nparser.varexp.TacletBuilderManipulators#main()print out Markdown documentation for the current known varconds.
Added therapi-javadoc to write Javadoc into resources to be read at runtime.
Type of pull request
Ensuring quality
.github/workflows/tests.yml