Skip to content

Fix condition to ignore TransparentFX in pr390 to fix issue #410. #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BrettRyland wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix condition to ignore TransparentFX in pr390 to fix issue #410. #423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion KSPCommunityFixes/BugFixes/PartBoundsIgnoreDisabledTransforms.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ static bool PartGeometryUtil_GetPartRendererBounds_Prefix(Part p, out Bounds[] _
//
// This matches the same rule as done in https://github.com/KSPModdingLibs/KSPCommunityFixes/issues/150
// which isn't really perfect, but is probably good enough for our purposes.
bool ignoreTransparentFX = !p.frozen;
bool ignoreTransparentFX = !p.frozen && !AllParentsTransparent(p.transform);

try
{
Expand All @@ -69,6 +69,12 @@ static bool PartGeometryUtil_GetPartRendererBounds_Prefix(Part p, out Bounds[] _

return false;
}
static bool AllParentsTransparent(Transform t)
{
if (t.gameObject.layer != LayerMask.NameToLayer("TransparentFX")) return false;
if (t.parent == null) return true;
return AllParentsTransparent(t.parent);
}

static readonly List<Renderer> rendererBuffer = [];

Expand Down