Correctly calculate consumedSystemFlux for consumers - #156
Merged
Merged
Conversation
This commit makes two different changes: - It rewrites `HeatLoop.AllocateFlux` to avoid the issue where `consumedSystemFlux` is set to 0 if a system's `totalSystemFlux` is equal to `totalFlux` when it is checked. - It changes the total flux available to allocate to also take into account negative flux used to lower the temperature of the loop. With these two changes `consumedSystemFlux` should now be accurate when the loop temperature is >= its nominal temperature. It should now be possible to actually use it to drive downstream things based on the amount of heat used (e.g. consuming resources, transferring heat, or powering an engine). I have taken care to make sure that the behaviour stays consistent when below the nominal temperature: flux will still be allocated to consumers based on the positive flux, even if this has no real effect on the loop itself. Fixes KSPModStewards#138
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes two different changes:
HeatLoop.AllocateFluxto avoid the issue whereconsumedSystemFluxis set to 0 if a system'stotalSystemFluxis equal tototalFluxwhen it is checked.With these two changes
consumedSystemFluxshould now be accurate when the loop temperature is >= its nominal temperature. It should now be possible to actually use it to drive downstream things based on the amount of heat used (e.g. consuming resources, transferring heat, or powering an engine).I have taken care to make sure that the behaviour stays consistent when below the nominal temperature: flux will still be allocated to consumers based on the positive flux, even if this has no real effect on the loop itself.
Fixes #138