Add an Enable HDR option - #87
Merged
Merged
Conversation
KSP2 can output HDR, but only with hdr-display-enabled=1 in KSP2_x64_Data/boot.config, and the game ships with it at 0. Each install profile now has Enable HDR next to Disable gfx jobs in Settings, off by default, and `installs set --hdr on|off` does the same from the CLI. `installs show` and the JSON output report it. It goes through the same path as graphics jobs: the setting is saved on the profile and written to the active install's boot.config whenever it changes. ApplyActiveInstallBootConfig now applies a list of keys and writes the file once if any of them changed, and the two profile setters share UpdateBootConfigSetting. With HDR off it writes hdr-display-enabled=0, which is what the game already ships, so a profile that never touches the option leaves boot.config as it was.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable HDR
KSP2 can output HDR, but only when
hdr-display-enabled=1is set inKSP2_x64_Data/boot.config, and the game ships with it at0. This adds an option for it, the same way we already handle graphics jobs.installs set --hdr on|off, andinstalls showplus the JSON output report it.boot.configwhenever it changes, through the same path asgfx-enable-gfx-jobs. Both keys are now applied in one pass, and the file is only rewritten when something actually changed.hdr-display-enabled=0, which is what the game already ships with, so nothing changes for anyone who leaves it off.