Repository navigation
fix: harden demo script and add CI services startup - #7
Merged
Merged
Conversation
JohnBasrai
commented
Feb 15, 2026
JohnBasrai
commented
Owner
- Update mom-rpc to 0.7.3
- Replace env_logger with tracing-subscriber
- Disable ANSI codes in logs for better script output
- Add set -m to demo.sh for proper signal handling to backgrounded processes
- Fix trap to use INT/TERM only (remove EXIT to avoid double cleanup)
- Add services startup step to CI qemu-smoke job (was missing, causing failures)
- Remove manual cleanup steps from README (now handled automatically by trap)
- Fix start-services.sh MQTT_PORT interpolation typo
- Add prerequisite note for local smoke test execution
- Update README expected output to reflect clean single-pass cleanup
- Update mom-rpc to 0.7.3 - Replace env_logger with tracing-subscriber - Disable ANSI codes in logs for better script output - Add set -m to demo.sh for proper signal handling to backgrounded processes - Fix trap to use INT/TERM only (remove EXIT to avoid double cleanup) - Add services startup step to CI qemu-smoke job (was missing, causing failures) - Remove manual cleanup steps from README (now handled automatically by trap) - Fix start-services.sh MQTT_PORT interpolation typo - Add prerequisite note for local smoke test execution - Update README expected output to reflect clean single-pass cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.