Store the VirusTotal API key in the Keychain - #30
Open
andrei-chernikov wants to merge 2 commits into
Open
andrei-chernikov wants to merge 2 commits into
andrei-chernikov wants to merge 2 commits into
Conversation
The API key was kept in UserDefaults, which means it sits in plain text in the app's preferences plist. It now lives in the login Keychain as a generic password (kSecAttrAccessibleWhenUnlockedThisDeviceOnly), and a key written by an earlier version is migrated on launch and removed from UserDefaults. The settings screen asks for confirmation the first time a key is saved, so the Keychain prompt is not a surprise, and trims whitespace around the key and username before verifying. Czech and Simplified Chinese strings are machine translations and are marked as such in the catalog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API key was kept in UserDefaults, which means it sits in plain text in the app's preferences plist.
kSecAttrAccessibleWhenUnlockedThisDeviceOnly).