Skip to content

chore(agama-engine): add default clauses to switch statements in Prim… - #15530

Draft
imran-ishaq wants to merge 1 commit into
mainfrom
agama-add-switch-default-clauses
Draft

imran-ishaq wants to merge 1 commit into
mainfrom
agama-add-switch-default-clauses

Conversation

@imran-ishaq

Copy link
Copy Markdown
Contributor

Description

Adds an explicit default: break; to three enum switch statements: one in PrimitiveUtils.primitiveNumberFrom and two in LogUtils.
No behavior change; each switch already falls through to the same code, and the engine compiles.

Target issue

Development item: switch statements without a default clause in the Agama engine.

closes #15529

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

…itiveUtils and LogUtils

Signed-off-by: imran <imranishaq7071@gmail.com>
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mo-auto

mo-auto commented Oct 28, 2026

Copy link
Copy Markdown
Member

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@mo-auto mo-auto added comp-agama Touching folder /agama comp-jans-auth-server Component affected by issue or PR kind-dependencies Pull requests that update a dependency file labels Oct 28, 2026
@imran-ishaq
imran-ishaq deployed to integration-tests October 28, 2026 15:03 — with GitHub Actions Active
@imran-ishaq
imran-ishaq deployed to integration-tests October 28, 2026 15:03 — with GitHub Actions Active
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed for 'Jans authentication server parent'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

This branch was successfully deployed

1 active deployment
integration-tests — 6b7047a6 Deployed Oct 28, 2026 by imran-ishaq via integration (PGSQL) #1374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp-agama Touching folder /agama comp-jans-auth-server Component affected by issue or PR kind-dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(agama-engine): add default clauses to switch statements in PrimitiveUtils and LogUtils

2 participants