fix(npm): detect musl libc to resolve correct binary on Alpine Linux#329
Open
aperkaz wants to merge 1 commit intoJamieMason:mainfrom
Open
fix(npm): detect musl libc to resolve correct binary on Alpine Linux#329aperkaz wants to merge 1 commit intoJamieMason:mainfrom
aperkaz wants to merge 1 commit intoJamieMason:mainfrom
Conversation
On Alpine and other musl-based distros, the glibc binary was resolved instead of the musl variant, causing: `Error relocating syncpack-linux-x64/bin/syncpack: __res_init: symbol not found`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (What)
Adds musl libc detection to the binary resolution logic in npm/index.cjs. On Linux, the launcher now checks /usr/bin/ldd for the presence of "musl" and appends -musl to the optional dependency name when detected, resolving to syncpack-linux-{arch}-musl instead of the glibc variant.
Justification (Why)
On Alpine Linux and other musl-based distros, syncpack fails at runtime with:
Error relocating /node_modules/syncpack-linux-x64/bin/syncpack: __res_init: symbol not foundThe glibc-linked binary is resolved because index.cjs has no way to distinguish musl from glibc — it only considers process.platform and process.arch. The musl binary packages (syncpack-linux-x64-musl, syncpack-linux-arm64-musl) are already built and published but were unreachable.
How Can This Be Tested?