Repository navigation
Conversation
Lets the parsing be reused for manifests that aren't retrieved through a channel manifest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At $WORK, we try to avoid hitting external services whenever we can, preferring to mirror as much as possible the content we use locally, so that outages don't affect us as much.
We use xwin to generate a cross-compilation toolchain from linux to windows. Unfortunately, this generation step is currently tied to microsoft's servers, and we have had CI failures related to microsoft's servers either being down or refusing to serve certain files from the CDN in the past. To remediate this, we'd like to be able to mirror the parts of the CDN we use locally.
To achieve this, this patch series does two things:
--package-manifestwhich allows passing the "package manifest" (aka VSMan, aka Catalog) to xwin.xwinalready has a--manifestflag, but unfortunately that takes a channel manifest instead of a package manifest, so it still requires "dereferencing" said channel manifest to grab the package manifest.--layout-urlflag, which should contain a Visual Studio layout - the official way to create a VS mirror. Those layouts should be created using the visual studio installer's--layoutflag, ergovs_community.exe --layout layout\. The layout can then be uploaded to an HTTP server and passed to other invocations to avoid hitting the MS servers.FWIW, there are some open questions here:
--package-manifest, perhaps the existing--manifestcould detect whether the file being passed is a channel or package manifest, and automatically adapt?