Skip to content

fix(web): include harness platforms in browse filter - #5807

Open
kkkhs wants to merge 1 commit into
JSONbored:mainfrom
kkkhs:agent/browse-harness-platform-filter
Open

kkkhs wants to merge 1 commit into
JSONbored:mainfrom
kkkhs:agent/browse-harness-platform-filter

Conversation

@kkkhs

@kkkhs kkkhs commented Aug 30, 2026

Copy link
Copy Markdown

Pull Request

Summary

Submission Source

For direct content PRs:

  • This PR changes exactly one content/<category>/<slug>.mdx file.
  • The entry includes source/provenance URLs and practical install/use details.
  • submittedBy and submittedByUrl match the PR author.
  • I did not modify README.md, generated registry outputs, downloads, workflows, packages, scripts, or multiple content entries.
  • I did not request HeyClaude-hosted /downloads/... package hosting for community-submitted ZIP/MCPB artifacts.
  • This PR links the issue it resolves, or the no-issue rationale is written in Notes.

For platform/code/docs PRs:

  • This is not a direct content submission.
  • Changed routes/components/endpoints/tools are listed below.
  • Screenshots or No visual impact are included when relevant.
  • This PR links the issue it resolves, or the no-issue maintainer-lane rationale is written in Notes.

For registry API endpoint PRs:

  • Route handler and central API contract changed together.
  • Origin-check and rate-limit posture is stated below.
  • OpenAPI/source generator impact is stated below; generated artifacts are not hand-edited unless maintainer/internal generation work is explicit.
  • API contract tests were added or updated.
  • Generator reproducibility was checked or the reason it was not checked is listed.

Schema and Quality Checks

  • Content PR: pnpm validate:content:strict passed, or I am relying on CI.
  • Platform/code PR: focused validation is listed below.
  • Package artifact PR: pnpm validate:packages and pnpm scan:packages passed.
  • No forbidden fields were added (viewCount, copyCount, popularityScore)
  • Install/use/copy paths are practical and complete.
  • Skill submissions include capability metadata when applicable (skillType, skillLevel, verificationStatus, verifiedAt, retrievalSources, testedPlatforms).

Quality Evidence

  • Changed routes/components/endpoints/tools: /browse platform filtering through matchesSearchFilters in apps/web/src/data/search.ts.
  • Expected behavior: ?platform= now includes entries whose compatibility is declared through entry.harness, matching the harness coverage surfaces.
  • Important edge cases or invariants: ordinary entry.platforms matches still pass; entries with no selected platform in either field still fail.
  • Backward compatibility notes: no schema or route changes.
  • Screenshots for frontend/page/UI changes:
    • Desktop:
    • Mobile:
  • If screenshots do not apply, write No visual impact and explain why: No visual impact — this only changes filter inclusion logic.
  • Accessibility notes for UI changes: none — no UI rendering changes.
  • Focused tests or reason tests are not practical: tests/search-lib-branch-coverage.test.ts covers a harness-only Windsurf entry matching a Windsurf platform filter.

Validation

  • Direct content PR: I did not run generation or commit generated output.
  • Platform/code PR: pnpm build passed, or the reason it was not run is listed below.
  • I ran the focused checks listed above.
  • I spot-checked the affected detail page(s), route(s), or integration surface(s), if applicable.

Notes

@kkkhs
kkkhs marked this pull request as ready for review August 30, 2026 08:52
@kkkhs
kkkhs requested a review from JSONbored as a code owner August 30, 2026 08:52
Copilot AI lite review requested due to automatic review settings August 30, 2026 08:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov

codecov Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.41%. Comparing base (8e8b85c) to head (91214fc).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5807   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files         534      534           
  Lines       16433    16435    +2     
  Branches     3765     3767    +2     
=======================================
+ Hits        15844    15846    +2     
  Misses        198      198           
  Partials      391      391           
Files with missing lines Coverage Δ
apps/web/src/data/search.ts 80.52% <100.00%> (+0.20%) ⬆️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: browse's platform filter omits entry.harness, diverging from every other harness/platform check in the codebase

2 participants