Extend vdim to support vector-valued kernels - #141
Merged
Conversation
- use `.git/info/exclude` for local ignores instead
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
==========================================
- Coverage 81.76% 76.38% -5.39%
==========================================
Files 25 25
Lines 4525 5471 +946
==========================================
+ Hits 3700 4179 +479
- Misses 825 1292 +467 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- sign mistake of volume potential of Green identity of `vdim` - sign mistake in the polynomial solution. Negation needed due to `-\Delta` convention
… volume potentials
What this commit does is execute X over scalar densities regarding the monomials as an FMM "charge" and request the FMM-based Hessian of the resulting potential, rather than before where we applied X to a dipole vector and took a gradient. The latter gradient-of-dipole computation is still the way that the `online' phase of the algorithm works, as there we truly do have a vector `g` input.
`HessianKernel` now accepts two modes of dispatch, charge vs. dipole, and the FMM, if supported for that mode, then executes respectively, a scalar->SMatrix computation or an SVector->SVector computation (the latter a dipole contraction of the input vector with the full Hessian).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.