fix(sdk): correct reviseProposal + setProposalBranch wire contracts#76
Merged
Merged
Conversation
ReviseProposalRequest carried a 'coverage' field the deployed
proposals/{id}/revise endpoint never reads — the real body field is
CoverageGroupIds (ReviseProposalEndpointRequest.cs). Reruns with
selected coverage groups silently degraded to current-groups reruns.
SetProposalBranchRequest used 'branchId' but the endpoint binds
AgentBranchId; the mismatch made every assignment clear the branch
instead of setting it. The endpoint also registers PUT, not POST —
the client now PUTs.
Both verified against InsurUp core WebApi endpoint + contract sources.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two proposal mutations drifted from the deployed API (source of truth:
ReviseProposalEndpointRequest.cs,SetProposalBranchEndpointRequest.cs,SetProposalBranchEndpoint.csin the core repo):reviseProposalcoverage?: Coverage— endpoint readsCoverageGroupIds; group-scoped reruns silently became current-group rerunscoverageGroupIds?: readonly string[] | nullsetProposalBranchbranchId: string— endpoint bindsAgentBranchId, so every call cleared the branch; client also POSTed where the endpoint registers PUT (405)agentBranchId: string | null+putNoContentNew wire-level unit tests assert both bodies + the PUT verb.
Test Plan
bun run typecheckbun run buildbun run test(incl. 2 new wire tests)bun run lint+format:check🤖 Generated with Claude Code