Skip to content

fix(iluvatar): avoid unavailable CUDA driver target #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gongchensu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(iluvatar): avoid unavailable CUDA driver target #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ foreach(source_file ${EXAMPLE_SOURCES})
RULE_LAUNCH_COMPILE "${ILUVATAR_CUDA_COMPILER} "
)
target_compile_options(${target_name} PRIVATE ${ILUVATAR_CUDA_FLAGS} "-Wno-unused-command-line-argument")
target_link_libraries(${target_name} PRIVATE CUDA::cudart CUDA::cuda_driver)
target_link_libraries(${target_name} PRIVATE CUDA::cudart)
endif()

if(WITH_METAX)
Expand Down
4 changes: 3 additions & 1 deletion src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,9 @@ if(WITH_ILUVATAR)
set(CMAKE_CXX_COMPILER "${ILUVATAR_CUDA_COMPILER}" CACHE FILEPATH "Iluvatar Compiler" FORCE)
target_compile_options(infiniccl PRIVATE ${ILUVATAR_CUDA_FLAGS})

target_link_libraries(infiniccl PRIVATE CUDA::cudart CUDA::cuda_driver)
# CoreX does not export `CUDA::cuda_driver`; this backend only uses the
# CUDA runtime API and NCCL.
Comment on lines +79 to +80

@Ziminli Ziminli Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个注释可以麻烦去掉一下，不太必要。

target_link_libraries(infiniccl PRIVATE CUDA::cudart)
endif()

# MetaX
Expand Down
Loading