feat: support CCL Reduce - #66
Open
GordonYang1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
Reducesupport to the shared CCL backend abstraction, including native bindings through the existing NCCL and MCCL provider layers for the existing publicinfinicclReduce()API. It also keeps inter-only communicators on the existing OpenMPI staging path during mixed-backend bootstrap flows, hardens the shared OpenMPI/MPICHReduceimplementation with typed-reduction validation, overflow checks, automatic host-buffer cleanup, and correct integerAvgscaling, defines zero-count behavior, makes the existing MPI example propagate validation failures, and includes CCL-only plus OpenMPI-assistedReduceexamples with correctness and communication-bandwidth reporting.Changes
Public API and Dispatch
infinicclReduce()API for configured CCL backends through generated bridge dispatch without changing its public signature.Reduceafter validating the communicator, data type, reduction operation, and root, without requiring non-null buffers or entering a backend.Common CCL Implementation
Reduceimplementation following the existingAllReducestructure.NotSupportedwhen the provider cannot represent either value.Existing CCL Provider Bindings
ncclReduce()andmcclReduce().Reducewith the existing NCCL and MCCL provider layers.MPI Correctness and Safety
MPI_Reduce()calls and reject data types that map toMPI_BYTE, avoiding invalid byte-wise reductions forFloat16andBFloat16.size_tbyte-size, and MPIintcount-range validation.Avgresults in floating point before converting them back to the destination type.Examples, Validation, and Metrics
Reduceexample using one shared unique ID and rank-based communicator initialization.Reduceexample that first exercises the MPI fallback through an inter-only communicator, then initializes the native CCL communicator for GPU reduction.nccl-testsReduceconvention, whose bus correction factor is1.Platform and Backend Affected
Platform
Backend
Performance Impact
This adds GPU-native NCCL and MCCL paths for
Reduce, avoiding the existing MPI host-staging path when a supported CCL backend and matching native communicator are available. The shared MPI path remains host-staged and retains typed reduction semantics with additional validation and cleanup. Other collective operations are intended to remain unchanged. The validation-log timings below are execution references rather than a quantified cross-backend performance comparison.Known Issues & Future Work
Reducealongside the existingAllReduce; other independently developed CCL collectives are outside this branch.Reduceinherits the backend/device combinations, data types, and reduction operations supported by the existing CCL providers; this PR does not add a new provider or device integration.Float32Sumpayloads on the default stream. Additional data types, reduction operations, non-default streams, in-place layouts, and runtime coverage on Iluvatar and Moore Threads remain future work.Float16andBFloat16arithmetic reductions until a typed host-conversion path is available, and rejects counts above the MPIintrange; chunked transfers remain future work.Test Results
The implementation commit is
5d8ac19c11e989caded690b75ed884653a25bfa5, a single commit directly based onef4045a2d99837c75c2acd90aae57dacb83172d2. The attached final evidence contains exactly 15 hash-verified canonical logs: all 15 targets passed, withCorrect: YES17 times andCorrect: NO0 times. The extra two positive results are the additional expected validation cases in the broadcast log.All four current-commit
Reducepaths passed with a 1,048,576-elementFloat32Sumpayload (4.00 MiB), 2 warm-up iterations, and 20 profiled iterations:The reported times are root-rank averages over the 20 profiled calls after the 2 warm-up calls.
Reduceuses a bus-bandwidth correction factor of1, so the reported algorithm and bus bandwidths are equal. The values were independently recomputed while accounting for the displayed time being rounded to three decimal places. They are included as execution evidence, not as a cross-platform benchmark comparison.Test Involved Platform
Test Involved Backend
Pure CCL (NCCL) on single-node NVIDIA:
ccl_all_reduce.log
ccl_reduce.log
CCL + MPI on single-node NVIDIA:
ccl_mpi_hybrid_all_reduce.log
ccl_mpi_hybrid_reduce.log
MPI on Heterogeneous Cluster:
mpi_all_gather.log
mpi_all_reduce.log
mpi_all_to_all.log
mpi_broadcast.log
mpi_gather.log
mpi_reduce.log
mpi_reduce_scatter.log
mpi_scatter.log
mpi_send_recv.log
Pure CCL (MCCL) on single-node MetaX:
ccl_all_reduce.log
ccl_reduce.log
Checklist
Title, Branch, and Commits
feat: …,fix(nccl): …).<type>/xxx-yyyy-zzzzwhere<type>matches the PR title's Conventional Commits type and words are joined with hyphens (seeCONTRIBUTING.md§Branches).CONTRIBUTING.md§Pull Requests).master— the branch is rebased cleanly on top of the currentmaster.fixup!/squash!/wipcommits remain.Scope and Design
CONTRIBUTING.md§Code/General).printf/std::cout/print(...)left behind, orTODOwithout an owner and issue link.General Code Hygiene
CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).the `AllReduce` implementation) (CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General; §Python).C++ Specific (if C++ files changed)
clang-format(version 16, per.github/workflows/clang-format.yml) has been run against all modified applicable files; the diff is clean.assertwith messages that include at least__FILE__,__LINE__, and__func__(CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).Python Specific (if Python files changed)
ruff checkpasses cleanly on CI (see `.github/workflows/ruff.yml).ruff format --checkpasses cleanly — if not, runruff formatand commit the result.CONTRIBUTING.md§Python).pytest.skipmessages without terminal period) are honored where applicable (CONTRIBUTING.md§Python).CONTRIBUTING.md§Python).if,for, and similar control-flow statements (CONTRIBUTING.md§Python).return, except when it directly follows a control-flow statement (CONTRIBUTING.md§Python).Testing
Build, CI, and Tooling
CMakeLists.txtunderif(AUTO_DETECT_DEVICES)or toif(AUTO_DETECT_BACKENDS)if applicable.clang-format.yml,ruff.yml) are green locally (or expected to be green on CI).Documentation
README.md,CONTRIBUTING.md, or inline docs updated when behavior, build flags, or developer workflow changed.!orBREAKING CHANGE:footer.Security and Safety