Repository navigation
fix(synced-roster): overload line names — use the game's real labels - #145
Merged
Merged
Conversation
data/ol-lines.json line names were invented ("Increase ATK", "Increase
Elemental Damage", …) and never matched the game's real strings from the CDN
equip_option_table_v2-en description_localkey ("Increased ATK", "Increased
Elemental Advantage Dmg", …), which the synced-roster backend forwards
verbatim. rosterApply's exact-match map therefore dropped EVERY synced user's
overload lines — all nine types surfaced in the unmapped banner (user report
2026-08-21; owner ruling: the strings never changed, ours were wrong from day
one). Rename the nine names to the real labels (stat/min/max values untouched;
everything else keys on line keys, not names), keep the old names as
OL_LABEL_ALIASES for pre-rename local roster captures, and pin the real
labels + legacy aliases + the unmodeled "Increased Recovery" diagnostic with
scripts/tests/data/ol-line-labels.test.ts. DECISIONS entry documents the
ruling and the live-CDN evidence.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… result Observed twice on 2026-08-23: detached/backgrounded, qwen finishes the review (final stream-json envelope with result+usage lands in the .raw.jsonl) but the CLI never exits, so the wrapper blocks forever and result.json is never written. Record the failure mode + the raw-envelope rescue recipe in the header (owner instruction: run this bridge foreground). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data/ol-lines.jsonline names were invented ("Increase ATK", "Increase Elemental Damage", …) and never matched the game's real strings ("Increased ATK", "Increased Elemental Advantage Dmg", …) that the synced-roster backend forwards verbatim from the CDNequip_option_table_v2-endescription_localkey— soweb/src/rosterApply.ts's exact-match map dropped every synced user's overload lines (all nine types in the unmapped banner; user report 2026-08-21). Owner ruling: the game strings never changed, ours were wrong from day one.stat/min/maxuntouched — everything else keys on line keys, not names), keep the old names asOL_LABEL_ALIASESfor pre-rename local roster captures, addscripts/tests/data/ol-line-labels.test.tspinning real labels + legacy aliases + the unmodeled "Increased Recovery" diagnostic, DECISIONS entry.scripts/dump-overload-labels.ts).Verification
bash scripts/verify.shgreen on this branch (worktree with regenerated web artifacts).🤖 Generated with Claude Code