Repository navigation
fix: prevent shell injection via workflow_dispatch BASELINE input - #133
Merged
Merged
Conversation
Pass BASELINE through env: instead of interpolating it directly into a run: block, quote it, and validate its format before any Azure login, build or deploy runs. The job holds id-token: write plus deployment secrets, so an attacker-controlled dispatch value could previously achieve arbitrary command execution on the runner. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
code-deploy.ymlinterpolated theworkflow_dispatchinputBASELINEdirectly into arun:block. A user with dispatch permission could inject shell metacharacters and, given the job holdsid-token: writeand all Azure deployment secrets, achieve arbitrary command execution on the runner.The input now travels through
env:(no shell interpretation), is quoted at use, and is validated against a strict branch-name regex before anything runs.Evidence
Validation regex checked offline against injection payloads:
Pre-commit ran
eslintand commitlint green. YAML parses cleanly; the only remaininggithub.event.inputs.BASELINEoccurrence is the safeenv:mapping.Merge Danger
Door: two-way (worst case: revert the commit / re-run dispatch)
Blast Radius: CI-only
Guards dispatch runs only; normal behavior (default
main,refs/heads/prefix stripped) is unchanged. Legitimate branch names with shell metacharacters outside the allowed set would now be rejected at job start, before Azure login.